Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Hide biometrical if device does not support it #3230

Merged
merged 5 commits into from
May 11, 2021
Merged

[Feature] Hide biometrical if device does not support it #3230

merged 5 commits into from
May 11, 2021

Conversation

JuancaG05
Copy link
Collaborator

@JuancaG05 JuancaG05 commented May 10, 2021 •
edited by jesmrec
Loading

Related Issues

App: #3217

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

QA checks: #3230 (comment)

@JuancaG05 JuancaG05 self-assigned this May 10, 2021
@JuancaG05 JuancaG05 linked an issue May 10, 2021 that may be closed by this pull request
[Improvement] Hide biometrical if device does not support it #3217
Closed
8 tasks
@JuancaG05 JuancaG05 marked this pull request as ready for review May 10, 2021 11:01
@JuancaG05 JuancaG05 requested review from abelgardep and theScrabi May 10, 2021 11:01
abelgardep
abelgardep suggested changes May 10, 2021
View reviewed changes
Copy link
Contributor

@abelgardep abelgardep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tiny suggestions here @JuancaG05

.../src/androidTest/java/com/owncloud/android/settings/security/SettingsSecurityFragmentTest.kt Show resolved Hide resolved
.../src/androidTest/java/com/owncloud/android/settings/security/SettingsSecurityFragmentTest.kt Outdated Show resolved Hide resolved
...ain/java/com/owncloud/android/presentation/ui/settings/fragments/SettingsSecurityFragment.kt Show resolved Hide resolved
@JuancaG05
Copy link
Collaborator Author

Applied that tiny change, ready for re-review @abelgardep

abelgardep
abelgardep approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@abelgardep abelgardep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Ready to QA @jesmrec

@abelgardep abelgardep mentioned this pull request May 11, 2021
Closed
8 tasks
@jesmrec
Copy link
Collaborator

jesmrec commented May 11, 2021

QA checks:

  • Device with no biometrical support - Passcode enabled, Biometrical hidden
  • Device with no biometrical support - Pattern enabled, Biometrical hidden
  • Device with biometrical support - Passcode and pattern disabled, Biometrical displayed and disabled
  • Device with biometrical support - Passcode enabled, Biometrical displayed and enabled
  • Device with biometrical support - Pattern enabled, Biometrical displayed and enabled

@jesmrec
Copy link
Collaborator

jesmrec commented May 11, 2021

Approved

@JuancaG05 JuancaG05 force-pushed the feature/hide_biometrics branch from a0de978 to af90518 Compare May 11, 2021 10:46
@JuancaG05 JuancaG05 merged commit e544a7e into master May 11, 2021
@JuancaG05 JuancaG05 deleted the feature/hide_biometrics branch May 11, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abelgardep abelgardep abelgardep approved these changes

@theScrabi theScrabi Awaiting requested review from theScrabi

Assignees

@JuancaG05 JuancaG05

Labels
Approved by qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improvement] Hide biometrical if device does not support it
3 participants
@JuancaG05 @jesmrec @abelgardep