Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align shared by link behaviour with other platforms #3007

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Align shared by link behaviour with other platforms #3007

merged 1 commit into from
Nov 9, 2020

Conversation

abelgardep
Copy link
Contributor

@abelgardep abelgardep commented Oct 26, 2020 •
edited by jesmrec
Loading

Implements #3003

QA

Test plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Release_2.16/3007-share_link_list_extended.md

Bugs & improvements:

@abelgardep abelgardep requested a review from theScrabi October 26, 2020 16:52
@abelgardep abelgardep self-assigned this Oct 26, 2020
@abelgardep abelgardep linked an issue Oct 27, 2020 that may be closed by this pull request
[BUG] Shared by link only shows files/folders from root #3003
Closed
@abelgardep abelgardep force-pushed the align/shared_by_link branch from 5bba954 to 404c563 Compare October 29, 2020 13:23
@jesmrec
Copy link
Collaborator

jesmrec commented Oct 30, 2020 •
edited
Loading

(1) [WONT FIX HERE]

  1. Create link on an item that is in root, and another one on an item that is not in root
  2. Open "Links" view -> both items are there
  3. From links view, open "Share" in every item and remove links created in 1.

Current: Item in root is not in the "Links" list anymore. Item in non-root stays in the list
Expected: Both items are not in the "Links" list anymore

Android11, Pixel2
commit 404c563

@abelgardep
Copy link
Contributor Author

abelgardep commented Oct 30, 2020 •
edited
Loading

About (1) It is a visual bug.

When we remove a share, we update shares database, but not files database. Files database is updated when we refresh a folder. So, at the moment, when we change something in the links view, that change is not visible until we refresh the folder that contains that file.

2 Options:

  • Refresh the folder that contains that file after any change in links view.
  • Update not only shares db but also files db after performing any change in links view.

@jesmrec
Copy link
Collaborator

jesmrec commented Nov 3, 2020

Update not only shares db but also files db after performing any change in links view.

This one is the most desirable. But... how feasible/costly is it?

@abelgardep
Copy link
Contributor Author

Update not only shares db but also files db after performing any change in links view.

This one is the most desirable. But... how feasible/costly is it?

It would be pretty simple if we had both tables (files and shares) in room database. But it is not the case, so it requires some work.

@michaelstingl
Copy link
Contributor

Do we plan to have both tables (files and shares) in room database? Just wait?

@abelgardep
Copy link
Contributor Author

Do we plan to have both tables (files and shares) in room database? Just wait?

Of course, we started working on it in #2955 . As soon as we have this in master, we could move this forward.

@michaelstingl
Copy link
Contributor

michaelstingl commented Nov 4, 2020 •
edited
Loading

No real urgency here. We can wait a bit…

Please update #3003

@jesmrec
Copy link
Collaborator

jesmrec commented Nov 4, 2020

Should we freeze this one till the database migration is merged into master?
or, should we merge this current approach, and fix (1) in the future when migration is merged into master?

I like the second option. What do you think?

@jesmrec
Copy link
Collaborator

jesmrec commented Nov 9, 2020

This is approved on my side. (1) will be improved in the future, so i will create new issue for that.

@abelgardep abelgardep force-pushed the align/shared_by_link branch from 404c563 to 22c369a Compare November 9, 2020 12:47
@abelgardep abelgardep merged commit e30fb84 into master Nov 9, 2020
@abelgardep abelgardep deleted the align/shared_by_link branch November 9, 2020 13:39
@jesmrec jesmrec mentioned this pull request Nov 10, 2020
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theScrabi theScrabi theScrabi approved these changes

Assignees

@abelgardep abelgardep

Labels
Approved by qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Shared by link only shows files/folders from root
4 participants
@abelgardep @jesmrec @michaelstingl @theScrabi