Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New arch] Share modularization #2597

Closed
wants to merge 23 commits into from
Closed

[New arch] Share modularization #2597

wants to merge 23 commits into from

Conversation

davigonz
Copy link
Contributor

@davigonz davigonz commented Jul 3, 2019 •
edited
Loading

Implements #2607
Needs owncloud/android-library#255

Bugs and improvements

  • (1) Use confirmation dialog to delete private shares, adapting the dialog title

@davigonz davigonz changed the base branch from master to new_arch/shares July 3, 2019 10:03
@davigonz davigonz changed the title [New arch] Modularization [New arch] Modularization [WIP] Jul 3, 2019
@davigonz davigonz mentioned this pull request Jul 3, 2019
Closed
@davigonz davigonz self-assigned this Jul 3, 2019
@davigonz davigonz mentioned this pull request Jul 3, 2019
Closed
@davigonz davigonz force-pushed the new_arch/modularization branch 2 times, most recently from db65d54 to f3fe2a0 Compare July 5, 2019 08:52
@davigonz davigonz mentioned this pull request Jul 9, 2019
Merged
7 tasks
@davigonz davigonz force-pushed the new_arch/modularization branch 2 times, most recently from 0ff325c to 2f069ea Compare July 17, 2019 11:58
@davigonz davigonz mentioned this pull request Jul 29, 2019
Closed
25 tasks
@davigonz davigonz force-pushed the new_arch/shares branch 2 times, most recently from 3c6c5d4 to a4feacf Compare August 7, 2019 07:42
@davigonz davigonz changed the base branch from new_arch/shares to master August 20, 2019 14:32
@davigonz davigonz changed the title [New arch] Modularization [WIP] [New arch] Shares modularization [WIP] Aug 20, 2019
@davigonz davigonz force-pushed the new_arch/modularization branch 3 times, most recently from a42fbaf to 5328e6f Compare August 28, 2019 08:28
davigonz added 12 commits August 28, 2019 12:48
@davigonz
Split up code into different modules following a layers approach
5a73bd6
@davigonz
Put tests in corresponding layers
6a30481
@davigonz
Start to use Mockk instead of Mockito since is better prepared to be …
7920664 
…used along with Kotlin
@davigonz
Fix tests using mockk instead of mockito, more prepared to work with …
2778d28 
…Kotlin instead of Java
@davigonz
Transform operations into usecases in domain model. Complete dependen…
f1f4a4d 
…cy injection [WIP]
@davigonz
Complete getPublicShares using different layers
c358d9a
@davigonz
Complete getPrivateShares using different layers and usecases
123042c
@davigonz
Handle private and public shares wit the same liveData
ef60e60
@davigonz
Public share creation using layers and usecases
1750bd2
@davigonz
Public share edition and removal using layers and usecases
14dde49
@davigonz
Capabilities along with layers and usecases
352dbc2
@davigonz
Solve conflicts with new_arch/shares branch and keep working on priva…
e0e253b 
…te shares
@davigonz davigonz force-pushed the new_arch/modularization branch from 5328e6f to 5e4ed63 Compare August 28, 2019 10:49
@davigonz davigonz force-pushed the new_arch/modularization branch from 5e4ed63 to a13c8a4 Compare August 28, 2019 10:50
@davigonz davigonz changed the title [New arch] Shares modularization [WIP] [New arch] Modularization, decoupling and new error handling [WIP] Oct 2, 2019
@davigonz
Copy link
Contributor Author

davigonz commented Oct 2, 2019

Closing this, please follow up #2675

@davigonz davigonz closed this Oct 2, 2019
@davigonz davigonz changed the title [New arch] Modularization, decoupling and new error handling [WIP] [New arch] Share modularization Oct 2, 2019
@davigonz davigonz mentioned this pull request Oct 2, 2019
Closed
@davigonz davigonz mentioned this pull request Nov 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davigonz davigonz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davigonz