-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New arch/shares #2487
New arch/shares #2487
Conversation
08a3398
to
26699ea
Compare
26699ea
to
29ce4cf
Compare
98722e0
to
f82ba8c
Compare
9421e7f
to
6f24ea1
Compare
a628fb5
to
92568de
Compare
5b4dc17
to
f2ff1aa
Compare
The code of this PR has been reviewed through several PRs, one for each feature. So, code approved, ready to test @jesmrec |
(3) [FIXED]Open Share view On the top left, the file thumbnail is not visible if the file is not a pic |
(4) [FIXED]
Current: Error NOTE: in specific folder permissions, also is reproducible. |
(5) [FIXED]
Current: Bad request |
(6) [FIXED]This one comes from (4). Repeat step 1. and in step 2. and then:
Current: Error message from step 2. stays in screen This one is only an aesthetic one, so no blocker and no must in case of trickiness. |
(7) [FIXED]
Current: Error "Password are enforced" is displayed NOTE: same error in editing mode |
…file and LiveData
…ving public link, icon does not change
3c6c5d4
to
a4feacf
Compare
Everything fixed, shares with new architecture done!! great job! |
Implements #2486
It needs owncloud/android-library#244
QA
Test plan:
https://github.com/owncloud/QA/blob/master/Mobile/Android/Release_2.12.0/Sharing%20-%20regression.md
BUGS & IMPROVEMENTS: