Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New arch/shares #2487

Merged
merged 229 commits into from
Aug 7, 2019
Merged

New arch/shares #2487

merged 229 commits into from
Aug 7, 2019

Conversation

davigonz
Copy link
Contributor

@davigonz davigonz commented Mar 15, 2019

Implements #2486
It needs owncloud/android-library#244


QA

Test plan:

https://github.com/owncloud/QA/blob/master/Mobile/Android/Release_2.12.0/Sharing%20-%20regression.md

BUGS & IMPROVEMENTS:

@davigonz davigonz force-pushed the new_arch/shares branch 3 times, most recently from 98722e0 to f82ba8c Compare April 9, 2019 17:10
@davigonz davigonz mentioned this pull request May 14, 2019
@davigonz davigonz force-pushed the new_arch/shares branch 2 times, most recently from 9421e7f to 6f24ea1 Compare May 24, 2019 11:31
@davigonz
Copy link
Contributor Author

davigonz commented Aug 6, 2019

The code of this PR has been reviewed through several PRs, one for each feature. So, code approved, ready to test @jesmrec

@davigonz davigonz requested a review from jesmrec August 6, 2019 06:51
@jesmrec
Copy link
Collaborator

jesmrec commented Aug 6, 2019

(3) [FIXED]

Open Share view

On the top left, the file thumbnail is not visible if the file is not a pic

@jesmrec
Copy link
Collaborator

jesmrec commented Aug 6, 2019

(4) [FIXED]

  1. User1 shares with User2, revoking Edit permission and granting Share permission
  2. User2 shares with User3 and try to grant Edit permission

Current: Error Not Found
Expected: Error that fits the scenario. Unfortunately, the error in 2.11.1 was not also the most appropriate (local copy could not be deleted)

NOTE: in specific folder permissions, also is reproducible.

@jesmrec
Copy link
Collaborator

jesmrec commented Aug 6, 2019

(5) [FIXED]

  1. Set the following capability set up:
  • Enforce password protection for upload-only (File Drop) links -> Enabled
  • Set default expiration date -> Enabled
  • Expire after X days (set the vale you want)
  1. Create a public link ver a folder with:
  • Name: no matter
  • Download/view permission
  • No password (not enforced for this level of permission)
  • Expiration: enforced and set, no changes needed
  1. Edit the link, setting in the following way:
  • Upload Only (file drop)
  • Set a password, since now is enforced by capability
  1. Save the edited link

Current: Bad request
Expected: Link saved

@jesmrec
Copy link
Collaborator

jesmrec commented Aug 6, 2019

(6) [FIXED]

This one comes from (4). Repeat step 1. and in step 2. and then:

  1. Grant user3 to share the item

Current: Error message from step 2. stays in screen
Expected: Error message removed

This one is only an aesthetic one, so no blocker and no must in case of trickiness.

@jesmrec
Copy link
Collaborator

jesmrec commented Aug 7, 2019

(7) [FIXED]

  1. Set the following capability set up:
  • Enforce password protection for read-only links -> Enabled
  • Enforce password protection for read&write links -> Disabled
  1. Create a public link over a folder with Download/view permission
  2. Save -> Error of enforced password is displayed
  3. Switch the permission to Download / View / Upload

Current: Error "Password are enforced" is displayed
Expected: After switching the permission to a new allowed one, the error is vanished.

NOTE: same error in editing mode

@davigonz davigonz self-assigned this Aug 7, 2019
@jesmrec
Copy link
Collaborator

jesmrec commented Aug 7, 2019

Everything fixed, shares with new architecture done!! great job!

@davigonz davigonz merged commit bf86491 into master Aug 7, 2019
@delete-merged-branch delete-merged-branch bot deleted the new_arch/shares branch August 7, 2019 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants