Display more info for changes #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rendering this results in the equivalent output of the design.
Example: <details> <summary><img width="14" alt="updated" src="https://raw.githubusercontent.com/overmindtech/ovm-cli/ac4feb1b9dd73b5c42c5a515d12517b551d2886b/assets/changed.png"> Deployment › api-server</summary> ```diff --- current +++ planned @@ -46,7 +46,6 @@ value: TRYMJyCxFCWU4FycHj1oztPyGyvtiv9f value_from: [] - name: API_KEY_CLIENT_SECRET - value: REDACTED value_from: [] - name: AUTH0_AUDIENCE value: https://api.overmind.tech ```
|
@dylanratcliffe please run this now through its paces. Note that there are some things that are displayed differently by the github parser and I found it easiest to paste the output into a comment box here and check the preview. |
|
Looks very good. The diff view in particular is excellent. Only thing would be that the empty state looks a but like a bug since there's an expand with nothing in there: 
I reckon either have an error in there, or render it as a dotpoint rather than a dropdown. If you go the error route maybe something like:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This displays mapped and unmapped items as well as attribute diffs from
tf plan.Templates from #111
Fixes #110