Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create desired markdown for new ovm-cli comment #111

Closed
dylanratcliffe opened this issue Nov 8, 2023 · 3 comments
Closed

Create desired markdown for new ovm-cli comment #111

dylanratcliffe opened this issue Nov 8, 2023 · 3 comments
Assignees

Comments

@dylanratcliffe
Copy link
Member

dylanratcliffe commented Nov 8, 2023

Provide examples of:

  • Unchanged
  • Created
  • Deleted
  • Replaced
  • Risks
  • No risks

Once this is done add the examples as a comment in #110 for implementation

@dylanratcliffe
Copy link
Member Author

dylanratcliffe commented Nov 10, 2023

mapped Expected Changes

changed Deployment › api_server
Once again a diff here

unmapped Unmapped Changes

Note

These changes couldn't be mapped to a real cloud resource and therefore won't be included in the blast radius calculation.

created auth0_action › add_to_crm
This should be diff with everything
changed auth0_action › create_account
code: |
  const { createPromiseClient } = require( "@connectrpc/connect")
  const { createConnectTransport } = require( "@connectrpc/connect-node")
- const { Auth0Support,Auth0CreateUserRequest } = require('@overmindtech/sdp-js')
+ const { Auth0Support} = require('@overmindtech/sdp-js')
  const ClientOAuth2 = require('client-oauth2')
  const transport = createConnectTransport({
---
      api.accessToken.setCustomClaim('https://api.overmind.tech/account-name', event.user.app_metadata.account_name)
      // wake up all sources
- const res = await client.keepaliveSources(
+ await client.keepaliveSources(
        {
          account: event.user.app_metadata.account_name,
        },

Blast Radius

mapped Items edge Edges
75 97

Open in Overmind

warning Risks

high Impact on Target Groups [High]

The various target groups including "944651592624.eu-west-2.elbv2-target-group.k8s-default-nats-4650f3a363", "944651592624.eu-west-2.elbv2-target-group.k8s-default-smartloo-fd2416d9f8", etc., that work alongside the load balancer for traffic routing may be indirectly affected if the security group change causes networking issues. This is especially important if these target groups rely on different ports other than 8080 for health checks or for directing incoming requests to backend services.

@dylanratcliffe
Copy link
Member Author

There is what I've come up with so far. Have asked Vasile to add some polish

@dylanratcliffe
Copy link
Member Author

Assets are provided in double the size to allow for high DPI screens:

  • Change 48*48: change
  • Item 32x32: item
  • Edge 32x32: edge
  • Created 28x28: created
  • Changed 28x28: changed
  • Deleted 28x28: deleted
  • Replaced 28x28: replaced
  • Risks 48x48: risks
  • High 36x36: high
  • Medium 36x36: medium
  • Low 36x36: low

Zip:

images.zip

Full comment: comment.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants