Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nutmeg.2 Release #715

Closed
wants to merge 3 commits into from
Closed

Nutmeg.2 Release #715

wants to merge 3 commits into from

Conversation

BbrSofiane
Copy link
Member

  • [Feature] Upgrade all applications to open-release/nutmeg.2.

regisb
regisb approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Is this still a draft?

@BbrSofiane BbrSofiane marked this pull request as ready for review August 9, 2022 20:33
@BbrSofiane
Copy link
Member Author

I've made it ready for review now.

I'm still building the image to do a quick check.

@BbrSofiane
Copy link
Member Author

I'm getting this error:

pymongo.errors.ServerSelectionTimeoutError: client is configured to connect to a replica set named '' but this node belongs to a set named 'None', Timeout: 30s, Topology Description: <TopologyDescription id: 62f34e196f500a0644fc30ee, topology_type: Single, servers: [<ServerDescription ('mongodb', 27017) server_type: Unknown, rtt: None, error=ConfigurationError("client is configured to connect to a replica set named '' but this node belongs to a set named 'None'")>]>

I'll look into later today.

@insad
Copy link

insad commented Aug 10, 2022

Something to do with openedx/edx-platform@46888e8 ?

@regisb
Copy link
Contributor

regisb commented Aug 10, 2022

I've got a bad feeling about this... I know that @kdmccormick pushed a fix for this change in the nightly branch but I can't find it now. If you are working on this, please make sure that the new tag is working for the MFE plugin as well. If you are sufficiently confident in the new tag, please ping me and send me an email.

@BbrSofiane BbrSofiane force-pushed the bbrsofiane/nutmeg-2-release branch from 25a89f0 to f216bc1 Compare August 14, 2022 15:58
@BbrSofiane
Copy link
Member Author

Thanks, @insad! I added these settings and it fixed the issue.

I'm not sure what impact it would have for someone using replica sets. Who would be a good person to ask?

@insad
Copy link

insad commented Aug 14, 2022 •
edited
Loading

Not using replica sets, but will try immediately this release.

Btw v14.0.5 is not being released still?

@kdmccormick
Copy link
Collaborator

@BbrSofiane , I think @regisb is thinking of @ormsbee 's pymongo fix here? #699

@BbrSofiane
Copy link
Member Author

Ah, thanks @kdmccormick!

@regisb don't merge this yet, I'll cherry-pick Dave's commit.

@BbrSofiane BbrSofiane force-pushed the bbrsofiane/nutmeg-2-release branch from f216bc1 to 481a45e Compare August 21, 2022 08:31
@BbrSofiane
fix: replica set error from pymongo 3.10 -> 3.12 upgrade
417feeb 
The pymongo dependency for edx-platform was updated (3.10.1 to 3.12.3)
in openedx/edx-platform#30569

This caused the following error when running the edx-platform database
migration split_modulestore_django.0002_data_migration as part of
`tutor dev quickstart`:

  pymongo.errors.ServerSelectionTimeoutError: client is configured to
  connect to a replica set named '' but this node belongs to a set named
  'None', Timeout: 30s, Topology Description: <TopologyDescription id:
  62bdbaf182687350acf1aeec, topology_type: Single, servers:
  [<ServerDescription ('mongodb', 27017) server_type: Unknown, rtt:
   None, error=ConfigurationError("client is configured to connect to a
   replica set named '' but this node belongs to a set named 'None'")>]>

This commit explicitly sets replicaSet to None to indicate that it's a
standalone MongoDB instance. I also had to remove the CONTENTSTORE entry
from auth.yml because edx-platform's devstack.py assumes it has a
non-null value (set in common.py), and devstack.py executes before
tutor's development.py can set this replicaSet value.
@BbrSofiane BbrSofiane force-pushed the bbrsofiane/nutmeg-2-release branch 2 times, most recently from 4f0d6cb to c4be4c1 Compare August 21, 2022 08:40
@BbrSofiane
v14.0.5 (2022-08-09)
1f58108 
- [Feature] Upgrade all applications to open-release/nutmeg.2.
@BbrSofiane BbrSofiane force-pushed the bbrsofiane/nutmeg-2-release branch from c4be4c1 to 1f58108 Compare August 21, 2022 08:40
@BbrSofiane
Copy link
Member Author

Done! This is ready to be merged.

fghaas
fghaas reviewed Aug 23, 2022
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@regisb
Copy link
Contributor

regisb commented Aug 29, 2022 •
edited
Loading

I changed the date as suggested above and then took the liberty to cherry-pick the commits. Thus I'm closing this now. A release will follow very shortly.

Thanks for your help @BbrSofiane!

@regisb regisb closed this Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fghaas fghaas fghaas left review comments

@regisb regisb regisb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BbrSofiane @insad @regisb @kdmccormick @fghaas