Remove Old Pymongo pin #30569

aht007 · 2022-06-10T13:02:18Z

This PR unpins Pymongo version from constraints file.
Pymongo >=3.11 would raise configuration error if replica set is empty string. Either we should pass replica set name which is already configured or pass it as None so that it serves as a standalone server.
For sandboxes, rs0 replica set is configured example but for devstack we don't have any so we are specifying it as None for devstack here in this PR.
For sandboxes a fix PR has been made which uses the already configured replica set and tested with this sandbox
For edx prod and stage we already have replica sets defined as can be seen here and being used so it wouldn't affect them.

awais786 · 2022-06-16T14:02:25Z

requirements/constraints.txt

@@ -36,9 +36,6 @@ django-oauth-toolkit<=1.3.2
 # Will be updated once we update python-dateutil package
 matplotlib<3.4.0

-# tests failing for pymongo==3.11


Add new pin here to avoid any major release.

adzuci

I don't understand the devstack bits, but this PR looks reasonable as long as some testing has been done

jmbowman · 2022-06-24T11:31:57Z

Just found a reported bug which should be fixed by this upgrade: https://discuss.openedx.org/t/mongodb-intermittent-connection-timeout-errors-in-pymongo-topology-py/7278 .

aht007 · 2022-06-24T15:05:13Z

@jmbowman The PR is ready and has been tested as well on sandboxes and devstack. It couldn't be merged today because of the flaky tests. They passed just now on 6th run though
I will make sure that it is ported back to the nutmeg release. Do we also need to do this for maple since I found out in conversation that it is also an issue on maple.

This reverts commit 8ef261f.

edx-pipeline-bot · 2022-06-27T10:53:48Z

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

edx-pipeline-bot · 2022-06-27T11:38:50Z

EdX Release Notice: This PR has been deployed to the production environment.

jmbowman · 2022-06-28T16:43:26Z

Maple is no longer supported, so I don't think any proactive effort is needed for that.

ormsbee · 2022-06-30T15:09:24Z

I was recently creating a new tutor dev instance with tutor dev quickstart and it errored out while trying to run the split_modulestore_django.0002_data_migration (which requires MongoDB access), with the trace:

  File "./manage.py", line 106, in <module>
    execute_from_command_line([sys.argv[0]] + django_args)
  File "/openedx/venv/lib/python3.8/site-packages/django/core/management/__init__.py", line 419, in execute_from_command_line
    utility.execute()
  File "/openedx/venv/lib/python3.8/site-packages/django/core/management/__init__.py", line 413, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/openedx/venv/lib/python3.8/site-packages/django/core/management/base.py", line 354, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/openedx/venv/lib/python3.8/site-packages/django/core/management/base.py", line 398, in execute
    output = self.handle(*args, **options)
  File "/openedx/venv/lib/python3.8/site-packages/django/core/management/base.py", line 89, in wrapped
    res = handle_func(*args, **kwargs)
  File "/openedx/venv/lib/python3.8/site-packages/django/core/management/commands/migrate.py", line 244, in handle
    post_migrate_state = executor.migrate(
  File "/openedx/venv/lib/python3.8/site-packages/django/db/migrations/executor.py", line 117, in migrate
    state = self._migrate_all_forwards(state, plan, full_plan, fake=fake, fake_initial=fake_initial)
  File "/openedx/venv/lib/python3.8/site-packages/django/db/migrations/executor.py", line 147, in _migrate_all_forwards
    state = self.apply_migration(state, migration, fake=fake, fake_initial=fake_initial)
  File "/openedx/venv/lib/python3.8/site-packages/django/db/migrations/executor.py", line 227, in apply_migration
    state = migration.apply(state, schema_editor)
  File "/openedx/venv/lib/python3.8/site-packages/django/db/migrations/migration.py", line 123, in apply
    operation.database_forwards(self.app_label, schema_editor, old_state, project_state)
  File "/openedx/venv/lib/python3.8/site-packages/django/db/migrations/operations/special.py", line 190, in database_forwards
    self.code(from_state.apps, schema_editor)
  File "/openedx/edx-platform/common/djangoapps/split_modulestore_django/migrations/0002_data_migration.py", line 26, in forwards_func
    for course_index in split_modulestore.db_connection.find_matching_course_indexes(force_mongo=True):
  File "/openedx/venv/lib/python3.8/site-packages/pymongo/cursor.py", line 1238, in next
    if len(self.__data) or self._refresh():
  File "/openedx/venv/lib/python3.8/site-packages/pymongo/cursor.py", line 1130, in _refresh
    self.__session = self.__collection.database.client._ensure_session()
  File "/openedx/venv/lib/python3.8/site-packages/pymongo/mongo_client.py", line 1935, in _ensure_session
    return self.__start_session(True, causal_consistency=False)
  File "/openedx/venv/lib/python3.8/site-packages/pymongo/mongo_client.py", line 1883, in __start_session
    server_session = self._get_server_session()
  File "/openedx/venv/lib/python3.8/site-packages/pymongo/mongo_client.py", line 1921, in _get_server_session
    return self._topology.get_server_session()
  File "/openedx/venv/lib/python3.8/site-packages/pymongo/topology.py", line 520, in get_server_session
    session_timeout = self._check_session_support()
  File "/openedx/venv/lib/python3.8/site-packages/pymongo/topology.py", line 499, in _check_session_support
    self._select_servers_loop(
  File "/openedx/venv/lib/python3.8/site-packages/pymongo/topology.py", line 218, in _select_servers_loop
    raise ServerSelectionTimeoutError(
pymongo.errors.ServerSelectionTimeoutError: client is configured to connect to a replica set named '' but this node belongs to a set named 'None', Timeout: 30s, Topology Description: <TopologyDescription id: 62bdbaf182687350acf1aeec, topology_type: Single, servers: [<ServerDescription ('mongodb', 27017) server_type: Unknown, rtt: None, error=ConfigurationError("client is configured to connect to a replica set named '' but this node belongs to a set named 'None'")>]>

I'm not sure if it's being caused by this PR or not, because I'm not really familiar with these settings. It just seemed suspicious. Looking into it more now.

ormsbee · 2022-06-30T15:17:49Z

Yeah, adding "replicaSet": None, to mongodb_parameters in Tutor got me past this error. I'm going to make a PR to Tutor for this, but I'm not really sure about the ramifications of this. Will link when I have the PR open. FYI @regisb

The pymongo dependency for edx-platform was updated (3.10.1 to 3.12.3) in openedx/edx-platform#30569 This caused the following error when running the edx-platform database migration split_modulestore_django.0002_data_migration as part of `tutor dev quickstart`: pymongo.errors.ServerSelectionTimeoutError: client is configured to connect to a replica set named '' but this node belongs to a set named 'None', Timeout: 30s, Topology Description: <TopologyDescription id: 62bdbaf182687350acf1aeec, topology_type: Single, servers: [<ServerDescription ('mongodb', 27017) server_type: Unknown, rtt: None, error=ConfigurationError("client is configured to connect to a replica set named '' but this node belongs to a set named 'None'")>]> This commit explicitly sets replicaSet to None to indicate that it's a standalone MongoDB instance.

ormsbee · 2022-06-30T15:34:18Z

PR made: overhangio/tutor#699

The pymongo dependency for edx-platform was updated (3.10.1 to 3.12.3) in openedx/edx-platform#30569 This caused the following error when running the edx-platform database migration split_modulestore_django.0002_data_migration as part of `tutor dev quickstart`: pymongo.errors.ServerSelectionTimeoutError: client is configured to connect to a replica set named '' but this node belongs to a set named 'None', Timeout: 30s, Topology Description: <TopologyDescription id: 62bdbaf182687350acf1aeec, topology_type: Single, servers: [<ServerDescription ('mongodb', 27017) server_type: Unknown, rtt: None, error=ConfigurationError("client is configured to connect to a replica set named '' but this node belongs to a set named 'None'")>]> This commit explicitly sets replicaSet to None to indicate that it's a standalone MongoDB instance. I also had to remove the CONTENTSTORE entry from auth.yml because edx-platform's devstack.py assumes it has a non-null value (set in common.py), and devstack.py executes before tutor's development.py can set this replicaSet value.

aht007 · 2022-07-01T07:44:25Z

@ormsbee

"replicaSet": None

Yeah this PR would cause issue with split_modulestore_django.0002_data_migration when trying to connect to mongodb if replicaSet is mentioned as empty string. If we don't have any setup for tutor then we are good to go with mentioning it as None. For devstack we didn't have any and hence I mentioned it as None in this PR, for sandboxes we had rs0 replica set configured and hence we are using that and we also have replica sets setup for stage and prod instances.

This reverts commit 8ef261f.

The pymongo dependency for edx-platform was updated (3.10.1 to 3.12.3) in openedx/edx-platform#30569 This caused the following error when running the edx-platform database migration split_modulestore_django.0002_data_migration as part of `tutor dev quickstart`: pymongo.errors.ServerSelectionTimeoutError: client is configured to connect to a replica set named '' but this node belongs to a set named 'None', Timeout: 30s, Topology Description: <TopologyDescription id: 62bdbaf182687350acf1aeec, topology_type: Single, servers: [<ServerDescription ('mongodb', 27017) server_type: Unknown, rtt: None, error=ConfigurationError("client is configured to connect to a replica set named '' but this node belongs to a set named 'None'")>]> This commit explicitly sets replicaSet to None to indicate that it's a standalone MongoDB instance. I also had to remove the CONTENTSTORE entry from auth.yml because edx-platform's devstack.py assumes it has a non-null value (set in common.py), and devstack.py executes before tutor's development.py can set this replicaSet value.

@ormsbee

- [Bugfix] Fix MongoDB replica set connection error resulting from edx-platform's pymongo (3.10.1 -> 3.12.3) upgrade ([edx-platform#30569](openedx/edx-platform#30569)). (by @ormsbee) - [Feature] Upgrade all applications to open-release/nutmeg.2.

chore: unpin pymongo

ca55b45

aht007 self-assigned this Jun 10, 2022

aht007 marked this pull request as draft June 10, 2022 15:03

aht007 force-pushed the aht007/PYMONGO-CONSTRAINT-INVESTIGATION branch 6 times, most recently from a303fdb to ca55b45 Compare June 15, 2022 12:36

aht007 and others added 4 commits June 15, 2022 17:48

fix: ran make upgrade

ba4a995

fix: add devstack configurations

315c1cd

fix: ran make upgrade

2e53adf

Merge branch 'master' into aht007/PYMONGO-CONSTRAINT-INVESTIGATION

b2cc7fc

awais786 reviewed Jun 16, 2022

View reviewed changes

awais786 approved these changes Jun 16, 2022

View reviewed changes

adzuci approved these changes Jun 17, 2022

View reviewed changes

aht007 changed the title ~~Unpin Pymongo~~ Remove Old Pymongo pin Jun 20, 2022

fix: add major version pin

004ab51

aht007 marked this pull request as ready for review June 20, 2022 12:17

dianakhuang approved these changes Jun 21, 2022

View reviewed changes

aht007 and others added 2 commits June 22, 2022 12:30

Merge branch 'master' into aht007/PYMONGO-CONSTRAINT-INVESTIGATION

357e1cc

fix: fix keys issue

9153f97

aht007 requested review from awais786 and iamsobanjaved June 23, 2022 12:00

awais786 approved these changes Jun 23, 2022

View reviewed changes

Merge branch 'master' into aht007/PYMONGO-CONSTRAINT-INVESTIGATION

ee3a082

aht007 merged commit 8ef261f into master Jun 27, 2022

aht007 deleted the aht007/PYMONGO-CONSTRAINT-INVESTIGATION branch June 27, 2022 09:37

aht007 added a commit that referenced this pull request Jun 27, 2022

Revert "Remove Old Pymongo pin (#30569)"

e9eb13c

This reverts commit 8ef261f.

aht007 mentioned this pull request Jun 27, 2022

Revert "Remove Old Pymongo pin" #30656

Closed

aht007 mentioned this pull request Jun 30, 2022

Remove Old Pymongo pin (#30569) #30657

Merged

regisb mentioned this pull request Jun 30, 2022

fix: replica set error from pymongo 3.10 -> 3.12 upgrade overhangio/tutor#699

Merged

aht007 added a commit that referenced this pull request Jul 1, 2022

Revert "Remove Old Pymongo pin (#30569)"

a2abd51

This reverts commit 8ef261f.

dcoa mentioned this pull request Aug 29, 2022

feat: add nutmeg compatibility (DS-211) eduNEXT/tutor-contrib-edunext-distro#24

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove Old Pymongo pin #30569

Remove Old Pymongo pin #30569

aht007 commented Jun 10, 2022 •

edited

Loading

awais786 Jun 16, 2022

aht007 Jun 20, 2022

adzuci left a comment

jmbowman commented Jun 24, 2022

aht007 commented Jun 24, 2022 •

edited

Loading

edx-pipeline-bot commented Jun 27, 2022

edx-pipeline-bot commented Jun 27, 2022

jmbowman commented Jun 28, 2022

ormsbee commented Jun 30, 2022

ormsbee commented Jun 30, 2022 •

edited

Loading

ormsbee commented Jun 30, 2022

aht007 commented Jul 1, 2022

Remove Old Pymongo pin #30569

Remove Old Pymongo pin #30569

Conversation

aht007 commented Jun 10, 2022 • edited Loading

awais786 Jun 16, 2022

Choose a reason for hiding this comment

aht007 Jun 20, 2022

Choose a reason for hiding this comment

adzuci left a comment

Choose a reason for hiding this comment

jmbowman commented Jun 24, 2022

aht007 commented Jun 24, 2022 • edited Loading

edx-pipeline-bot commented Jun 27, 2022

edx-pipeline-bot commented Jun 27, 2022

jmbowman commented Jun 28, 2022

ormsbee commented Jun 30, 2022

ormsbee commented Jun 30, 2022 • edited Loading

ormsbee commented Jun 30, 2022

aht007 commented Jul 1, 2022

aht007 commented Jun 10, 2022 •

edited

Loading

aht007 commented Jun 24, 2022 •

edited

Loading

ormsbee commented Jun 30, 2022 •

edited

Loading