fix(windows/install): allow linking bins that do not exist. #8605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ @paperdave 2 files with test failures on bun-darwin-aarch64:
|
|
❌ @paperdave 4 files with test failures on linux-x64:
|
|
❌ @paperdave 5 files with test failures on linux-x64-baseline: |
|
❌ @paperdave 5 files with test failures on bun-darwin-x64:
|
❌🪟 @paperdave, there are 7 test regressions on Windows x86_64
|
ryoppippi
pushed a commit
to ryoppippi/bun
that referenced
this pull request
Feb 1, 2024
gvilums
pushed a commit
that referenced
this pull request
Feb 1, 2024
Jarred-Sumner
pushed a commit
that referenced
this pull request
Feb 1, 2024
* draft impl of windows watcher * synchronous watcher * working standalone watcher * in progress changes to watcher * make watcher non-global * prepare watcher for windows impl * add windows watcher scaffold and clean up imports * fix inotify * make watch code more generic over platforms * fix visibility * watcher starts without error * printing changes works * basic windows watching works * handle process exit from watcher * cleanup in process cloning * clean up logging and panic handling * fix hot reload test on windows * misc cleanup around watcher * make watch test actually useful * [autofix.ci] apply automated fixes * remove old files * clean up watchers * update .gitignore * rework windows watcher into single watcher instance watching top level project dir * use non-strict utf16 conversion * change to contains * fix mac and linux compile * add baseline in crash report (#8606) * allow linking bins that do not exist. (#8605) * fix linux compile * fix linux compile (again) * remove outdated todo --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: dave caruso <[email protected]>
ryoppippi
pushed a commit
to ryoppippi/bun
that referenced
this pull request
Feb 2, 2024
* draft impl of windows watcher * synchronous watcher * working standalone watcher * in progress changes to watcher * make watcher non-global * prepare watcher for windows impl * add windows watcher scaffold and clean up imports * fix inotify * make watch code more generic over platforms * fix visibility * watcher starts without error * printing changes works * basic windows watching works * handle process exit from watcher * cleanup in process cloning * clean up logging and panic handling * fix hot reload test on windows * misc cleanup around watcher * make watch test actually useful * [autofix.ci] apply automated fixes * remove old files * clean up watchers * update .gitignore * rework windows watcher into single watcher instance watching top level project dir * use non-strict utf16 conversion * change to contains * fix mac and linux compile * add baseline in crash report (oven-sh#8606) * allow linking bins that do not exist. (oven-sh#8605) * fix linux compile * fix linux compile (again) * remove outdated todo --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: dave caruso <[email protected]>
Hanaasagi
pushed a commit
to Hanaasagi/bun
that referenced
this pull request
Feb 3, 2024
Hanaasagi
pushed a commit
to Hanaasagi/bun
that referenced
this pull request
Feb 3, 2024
* draft impl of windows watcher * synchronous watcher * working standalone watcher * in progress changes to watcher * make watcher non-global * prepare watcher for windows impl * add windows watcher scaffold and clean up imports * fix inotify * make watch code more generic over platforms * fix visibility * watcher starts without error * printing changes works * basic windows watching works * handle process exit from watcher * cleanup in process cloning * clean up logging and panic handling * fix hot reload test on windows * misc cleanup around watcher * make watch test actually useful * [autofix.ci] apply automated fixes * remove old files * clean up watchers * update .gitignore * rework windows watcher into single watcher instance watching top level project dir * use non-strict utf16 conversion * change to contains * fix mac and linux compile * add baseline in crash report (oven-sh#8606) * allow linking bins that do not exist. (oven-sh#8605) * fix linux compile * fix linux compile (again) * remove outdated todo --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: dave caruso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before:
now, the install succeeds but since the lifecycle script is not run, we get this new error upon running it:
This is half of #8591