--watch and --hot on windows (oven-sh#8607)

* draft impl of windows watcher

* synchronous watcher

* working standalone watcher

* in progress changes to watcher

* make watcher non-global

* prepare watcher for windows impl

* add windows watcher scaffold and clean up imports

* fix inotify

* make watch code more generic over platforms

* fix visibility

* watcher starts without error

* printing changes works

* basic windows watching works

* handle process exit from watcher

* cleanup in process cloning

* clean up logging and panic handling

* fix hot reload test on windows

* misc cleanup around watcher

* make watch test actually useful

* [autofix.ci] apply automated fixes

* remove old files

* clean up watchers

* update .gitignore

* rework windows watcher into single watcher instance watching top level project dir

* use non-strict utf16 conversion

* change to contains

* fix mac and linux compile

* add baseline in crash report (oven-sh#8606)

* allow linking bins that do not exist. (oven-sh#8605)

* fix linux compile

* fix linux compile (again)

* remove outdated todo

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: dave caruso <[email protected]>

.gitignore

@@ -1,166 +1,167 @@
-.DS_Store
-zig-cache
-packages/*/*.wasm
-*.o
-*.a
-profile.json
-
-node_modules
-.envrc
-.swcrc
-yarn.lock
-dist
-*.tmp
-*.log
-*.out.js
-*.out.refresh.js
-**/package-lock.json
-build
-*.wat
-zig-out
-pnpm-lock.yaml
-README.md.template
-src/deps/zig-clap/example
-src/deps/zig-clap/README.md
-src/deps/zig-clap/.github
-src/deps/zig-clap/.gitattributes
-out
-outdir
-
-.trace
-cover
-coverage
-coverv
-*.trace
-github
-out.*
-out
-.parcel-cache
-esbuilddir
-*.bun
-parceldist
-esbuilddir
-outdir/
-outcss
-.next
-txt.js
-.idea
-.vscode/cpp*
-.vscode/clang*
-
-node_modules_*
-*.jsb
-*.zip
-bun-zigld
-bun-singlehtreaded
-bun-nomimalloc
-bun-mimalloc
-examples/lotta-modules/bun-yday
-examples/lotta-modules/bun-old
-examples/lotta-modules/bun-nofscache
-
-src/node-fallbacks/out/*
-src/node-fallbacks/node_modules
-sign.json
-release/
-*.dmg
-sign.*.json
-packages/debug-*
-packages/bun-cli/postinstall.js
-packages/bun-*/bun
-packages/bun-*/bun-profile
-packages/bun-*/debug-bun
-packages/bun-*/*.o
-packages/bun-cli/postinstall.js
-
-packages/bun-cli/bin/*
-bun-test-scratch
-misctools/fetch
-
-src/deps/libiconv
-src/deps/openssl
-src/tests.zig
-*.blob
-src/deps/s2n-tls
-.npm
-.npm.gz
-
-bun-binary
-
-src/deps/PLCrashReporter/
-
-*.dSYM
-*.crash
-misctools/sha
-packages/bun-wasm/*.mjs
-packages/bun-wasm/*.cjs
-packages/bun-wasm/*.map
-packages/bun-wasm/*.js
-packages/bun-wasm/*.d.ts
-packages/bun-wasm/*.d.cts
-packages/bun-wasm/*.d.mts
-*.bc
-
-src/fallback.version
-src/runtime.version
-*.sqlite
-*.database
-*.db
-misctools/machbench
-*.big
-.eslintcache
-
-/bun-webkit
-
-src/deps/c-ares/build
-src/bun.js/bindings-obj
-src/bun.js/debug-bindings-obj
-
-failing-tests.txt
-test.txt
-myscript.sh
-
-cold-jsc-start
-cold-jsc-start.d
-
-/test.ts
-/test.js
-
-src/js/out/modules*
-src/js/out/functions*
-src/js/out/tmp
-src/js/out/DebugPath.h
-
-make-dev-stats.csv
-
-.uuid
-tsconfig.tsbuildinfo
-
-test/js/bun/glob/fixtures
-*.lib
-*.pdb
-CMakeFiles
-build.ninja
-.ninja_deps
-.ninja_log
-CMakeCache.txt
-cmake_install.cmake
-compile_commands.json
-
-*.lib
-x64
-**/*.vcxproj*
-**/*.sln*
-**/*.dir
-**/*.pdb
-
-/.webkit-cache
-/.cache
-/src/deps/libuv
-/build-*/
-
-.vs
-
-**/.verdaccio-db.json
-/test-report.md
+.DS_Store
+zig-cache
+packages/*/*.wasm
+*.o
+*.a
+profile.json
+
+node_modules
+.envrc
+.swcrc
+yarn.lock
+dist
+*.tmp
+*.log
+*.out.js
+*.out.refresh.js
+**/package-lock.json
+build
+*.wat
+zig-out
+pnpm-lock.yaml
+README.md.template
+src/deps/zig-clap/example
+src/deps/zig-clap/README.md
+src/deps/zig-clap/.github
+src/deps/zig-clap/.gitattributes
+out
+outdir
+
+.trace
+cover
+coverage
+coverv
+*.trace
+github
+out.*
+out
+.parcel-cache
+esbuilddir
+*.bun
+parceldist
+esbuilddir
+outdir/
+outcss
+.next
+txt.js
+.idea
+.vscode/cpp*
+.vscode/clang*
+
+node_modules_*
+*.jsb
+*.zip
+bun-zigld
+bun-singlehtreaded
+bun-nomimalloc
+bun-mimalloc
+examples/lotta-modules/bun-yday
+examples/lotta-modules/bun-old
+examples/lotta-modules/bun-nofscache
+
+src/node-fallbacks/out/*
+src/node-fallbacks/node_modules
+sign.json
+release/
+*.dmg
+sign.*.json
+packages/debug-*
+packages/bun-cli/postinstall.js
+packages/bun-*/bun
+packages/bun-*/bun-profile
+packages/bun-*/debug-bun
+packages/bun-*/*.o
+packages/bun-cli/postinstall.js
+
+packages/bun-cli/bin/*
+bun-test-scratch
+misctools/fetch
+
+src/deps/libiconv
+src/deps/openssl
+src/tests.zig
+*.blob
+src/deps/s2n-tls
+.npm
+.npm.gz
+
+bun-binary
+
+src/deps/PLCrashReporter/
+
+*.dSYM
+*.crash
+misctools/sha
+packages/bun-wasm/*.mjs
+packages/bun-wasm/*.cjs
+packages/bun-wasm/*.map
+packages/bun-wasm/*.js
+packages/bun-wasm/*.d.ts
+packages/bun-wasm/*.d.cts
+packages/bun-wasm/*.d.mts
+*.bc
+
+src/fallback.version
+src/runtime.version
+*.sqlite
+*.database
+*.db
+misctools/machbench
+*.big
+.eslintcache
+
+/bun-webkit
+
+src/deps/c-ares/build
+src/bun.js/bindings-obj
+src/bun.js/debug-bindings-obj
+
+failing-tests.txt
+test.txt
+myscript.sh
+
+cold-jsc-start
+cold-jsc-start.d
+
+/testdir
+/test.ts
+/test.js
+
+src/js/out/modules*
+src/js/out/functions*
+src/js/out/tmp
+src/js/out/DebugPath.h
+
+make-dev-stats.csv
+
+.uuid
+tsconfig.tsbuildinfo
+
+test/js/bun/glob/fixtures
+*.lib
+*.pdb
+CMakeFiles
+build.ninja
+.ninja_deps
+.ninja_log
+CMakeCache.txt
+cmake_install.cmake
+compile_commands.json
+
+*.lib
+x64
+**/*.vcxproj*
+**/*.sln*
+**/*.dir
+**/*.pdb
+
+/.webkit-cache
+/.cache
+/src/deps/libuv
+/build-*/
+
+.vs
+
+**/.verdaccio-db.json
+/test-report.md
 /test-report.json

src/__global.zig

@@ -69,6 +69,8 @@ pub fn setThreadName(name: StringTypes.stringZ) void {
         _ = std.os.prctl(.SET_NAME, .{@intFromPtr(name.ptr)}) catch 0;
     } else if (Environment.isMac) {
         _ = std.c.pthread_setname_np(name);
+    } else if (Environment.isWindows) {
+        // _ = std.os.SetThreadDescription(std.os.GetCurrentThread(), name);
     }
 }
 

src/bun.js/event_loop.zig

@@ -1178,14 +1178,10 @@ pub const EventLoop = struct {
         }
 
         if (!loop.isActive()) {
-            if (comptime Environment.isWindows) {
-                bun.todo(@src(), {});
-            } else {
-                if (this.forever_timer == null) {
-                    var t = uws.Timer.create(loop, this);
-                    t.set(this, &noopForeverTimer, 1000 * 60 * 4, 1000 * 60 * 4);
-                    this.forever_timer = t;
-                }
+            if (this.forever_timer == null) {
+                var t = uws.Timer.create(loop, this);
+                t.set(this, &noopForeverTimer, 1000 * 60 * 4, 1000 * 60 * 4);
+                this.forever_timer = t;
             }
         }