Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

js: fix Buffer constructor and Buffer.from #16731

Merged
merged 10 commits into from
Feb 7, 2025
Merged

js: fix Buffer constructor and Buffer.from #16731

merged 10 commits into from
Feb 7, 2025

Conversation

nektro
Copy link
Member

@nektro nektro commented Jan 25, 2025

pulled out of #15722

@robobun
Copy link

robobun commented Jan 25, 2025 •
edited
Loading

Updated 9:58 PM PT - Feb 6th, 2025

❌ @nektro, your commit 857015a has 2 failures in Build #11248:

🧪   try this PR locally:

bunx bun-pr 16731

@nektro nektro marked this pull request as ready for review January 25, 2025 02:10
@nektro nektro requested review from a team and zackradisic and removed request for a team January 25, 2025 02:26
@nektro
Copy link
Member Author

nektro commented Jan 25, 2025

from reference https://github.com/nodejs/node/blob/v23.6.0/lib/buffer.js#L298

@nektro nektro marked this pull request as draft January 25, 2025 08:53
@nektro nektro marked this pull request as ready for review January 27, 2025 23:59
Jarred-Sumner
Jarred-Sumner reviewed Feb 5, 2025
View reviewed changes
src/codegen/generate-classes.ts Outdated
@@ -2281,7 +2281,7 @@ JSC_DEFINE_HOST_FUNCTION(Zig::jsFunctionInherits, (JSC::JSGlobalObject * globalO
switch (id) {
${jsclasses
.map(v => v[0])
.map((v, i) => ` case ${i}: return JSValue::encode(jsBoolean(cell->inherits<WebCore::JS${v}>()));`)
.map((v, i) => ` case ${i}: return JSValue::encode(jsBoolean(jsDynamicCast<WebCore::JS${v}*>(cell) != nullptr));`)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what was the purpose of this change?

Jarred-Sumner
Jarred-Sumner requested changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@Jarred-Sumner Jarred-Sumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions

@nektro nektro requested a review from Jarred-Sumner February 7, 2025 06:19
@Jarred-Sumner Jarred-Sumner merged commit 1805001 into main Feb 7, 2025
66 of 69 checks passed
@Jarred-Sumner Jarred-Sumner deleted the nektro-patch-29530 branch February 7, 2025 23:13
@heimskr
Copy link
Member

heimskr commented Feb 11, 2025

This causes Buffer.from(new ArrayBuffer()) to throw a TypeError

@190n 190n mentioned this pull request Feb 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zackradisic zackradisic Awaiting requested review from zackradisic zackradisic was automatically assigned from oven-sh/code-reviewers

@Jarred-Sumner Jarred-Sumner Awaiting requested review from Jarred-Sumner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nektro @robobun @heimskr @Jarred-Sumner