Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: fix Buffer.from(arrayBuffer) #17267

Merged
merged 3 commits into from
Feb 12, 2025
Merged

node: fix Buffer.from(arrayBuffer) #17267

merged 3 commits into from
Feb 12, 2025

Conversation

nektro
Copy link
Member

@nektro nektro commented Feb 11, 2025

thanks @heimskr for the discovery!

@robobun
Copy link

robobun commented Feb 11, 2025

Updated 5:16 PM PT - Feb 11th, 2025

@nektro, your commit 78c1e3c has 3 failures in Build #11460:


🧪   try this PR locally:

bunx bun-pr 17267

@nektro nektro marked this pull request as ready for review February 12, 2025 01:33
@nektro nektro requested a review from 190n February 12, 2025 01:33
Copy link
Contributor

@190n 190n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, I'd just like a bit more testing

test/js/node/buffer.test.js Show resolved Hide resolved
test/js/node/buffer.test.js Show resolved Hide resolved
@nektro nektro merged commit bdccbbc into main Feb 12, 2025
58 of 69 checks passed
@nektro nektro deleted the nektro-patch-35865 branch February 12, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants