Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This should only be merged after #15437 and #16223 are merged (because those are broad Node-API refactors, and merging more Node-API stuff into
main
will just make more conflicts for merging those PRs).This is a few commits from #14501 split into a separate PR. Fixes:
napi_define_class
did not check if all its arguments areNULL
napi_coerce
functions didn't handle exceptions correctlynapi_get_value_bool
didn't handle non-booleans correctlyNULL
fromnapi_get_cb_info
instead of the data pointer provided when the class was createdHow did you verify your code works?
Current Node-API tests pass.