Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up napi envs #15437

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Split up napi envs #15437

wants to merge 16 commits into from

Conversation

heimskr
Copy link
Member

@heimskr heimskr commented Nov 27, 2024

What does this PR do?

This PR allows multiple napi envs per global object to exist at once.

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

Ran our napi tests and made sure none of Node's napi tests failed compared to the current stable release of Bun.

@robobun
Copy link

robobun commented Nov 27, 2024

Updated 4:44 PM PT - Jan 8th, 2025

@190n, your commit f73edb4 has passed in #9261! 🎉


🧪   try this PR locally:

bunx bun-pr 15437

@heimskr
Copy link
Member Author

heimskr commented Nov 27, 2024

Whoops, tried to use dlsym on Windows

Copy link
Contributor

@190n 190n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review comments + this needs a test

src/bun.js/bindings/BunProcess.cpp Outdated Show resolved Hide resolved
src/bun.js/bindings/ZigGlobalObject.h Outdated Show resolved Hide resolved
src/bun.js/bindings/napi.cpp Outdated Show resolved Hide resolved
src/bun.js/bindings/napi.h Outdated Show resolved Hide resolved
src/bun.js/bindings/napi_external.h Outdated Show resolved Hide resolved
@heimskr heimskr requested a review from 190n December 9, 2024 22:42
test/napi/napi-app/module.js Outdated Show resolved Hide resolved
@190n 190n requested a review from a team January 7, 2025 02:22
@RiskyMH RiskyMH requested review from a team and removed request for a team January 7, 2025 22:56
@190n 190n requested review from a team and paperclover and removed request for Jarred-Sumner and a team January 7, 2025 22:58
@190n 190n mentioned this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants