Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Wrong implementation of u_t(x|z) in Brownian Bridge #600

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

selmanozleyen
Copy link
Contributor

fixes #595 and changes the naming

@marcocuturi
Copy link
Contributor

Thanks @selmanozleyen ! I think you need to fix the tests as well to comply with your new variable names

@michalk8 michalk8 added the bug Something isn't working label Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.16%. Comparing base (2ffd45f) to head (23abcf1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ott/neural/methods/flows/dynamics.py 66.66% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #600      +/-   ##
==========================================
- Coverage   88.19%   88.16%   -0.04%     
==========================================
  Files          74       74              
  Lines        7760     7764       +4     
  Branches      544      544              
==========================================
+ Hits         6844     6845       +1     
- Misses        775      778       +3     
  Partials      141      141              
Files with missing lines Coverage Δ
src/ott/neural/methods/flows/genot.py 85.12% <100.00%> (ø)
src/ott/neural/methods/flows/otfm.py 97.01% <100.00%> (ø)
src/ott/neural/methods/flows/dynamics.py 88.23% <66.66%> (-8.44%) ⬇️

@selmanozleyen
Copy link
Contributor Author

Ok, I made the changes, it should be ready review @michalk8 @marcocuturi

@marcocuturi
Copy link
Contributor

thanks @selmanozleyen :) the preferred way to ping for review is to use the tool up there, in the right, to assign reviewers :)

@michalk8 michalk8 self-requested a review November 28, 2024 14:10
Copy link
Collaborator

@michalk8 michalk8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@michalk8 michalk8 merged commit 561adbb into ott-jax:main Nov 28, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong implementation of u_t(x|z) in Brownian Bridge
3 participants