New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong implementation of u_t(x|z) in Brownian Bridge #595

Closed

selmanozleyen opened this issue Nov 10, 2024 · 1 comment · Fixed by #600

Contributor

selmanozleyen commented Nov 10, 2024

Hi,
I was reading the tong et al 23 paper and noticed the implementation might be wrong here. As I was using this flow for my thesis project already.

In the implementation ut() = x1-x0 but in the paper it is

ott/src/ott/neural/methods/flows/dynamics.py

Line 143 in 828acca

class BrownianBridge(StraightFlow):

Contributor

MUCDK commented Nov 11, 2024

Good point @selmanozleyen , can you open a PR?

selmanozleyen mentioned this issue

Fix Wrong implementation of u_t(x|z) in Brownian Bridge #600

Merged

michalk8 closed this as completed in #600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment