-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactoring UnivariateSolver
#472
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #472 +/- ##
==========================================
- Coverage 90.45% 90.41% -0.04%
==========================================
Files 58 59 +1
Lines 6350 6440 +90
Branches 894 912 +18
==========================================
+ Hits 5744 5823 +79
- Misses 467 472 +5
- Partials 139 145 +6
|
also of interest for @JTT94 since could impact soft sorting initializers |
michalk8
requested changes
Nov 27, 2023
michalk8
reviewed
Nov 27, 2023
michalk8
reviewed
Nov 27, 2023
michalk8
reviewed
Nov 27, 2023
michalk8
reviewed
Nov 27, 2023
michalk8
reviewed
Nov 27, 2023
michalk8
reviewed
Nov 27, 2023
michalk8
reviewed
Nov 27, 2023
michalk8
reviewed
Nov 27, 2023
michalk8
pushed a commit
that referenced
this pull request
Jun 27, 2024
Merging as docs issue comes from recent `neural` refactoring. * refactoring * refactoring following michal comments * fix tests * last fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on @Daniel-Packer 's implementation
UnivariateSolver
more in agreement with other implementations (takes a problem as input now)UnivariateSolver
can now take a standardprob
on point clouds of size[n,d]
. This means thatd
independent slices will be considered, running 1D OT on each of them.a
andb
of all flavors, and simplifications (essentially no need to passmethod
string, only arguments such asnum_subsamples
orquantiles
. If those are passed then user intends to use these alternative methods. Otherwise, select automatically the good method by checking problem's nature (in particularn=m
and weights were uniform (only weaknesses: only checks if those were by default, don't see obvious workaround to test numerically)UnivariateOutput
namedtuple.UnivariateWasserstein
is now a new cost for point clouds. This makes sense forlower_bound.py
and slightly alleviates code there, rather than using the double vmap that is considered by default in the.pairwise
method of aCostFn