Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for lower bound #456

Closed

Conversation

Daniel-Packer
Copy link
Contributor

Added ott.solvers.quadratic.lowerbound.LowerBoundSolver to the Gromov-Wasserstein Documentation.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Daniel-Packer Daniel-Packer marked this pull request as draft November 7, 2023 20:54
@michalk8
Copy link
Collaborator

@Daniel-Packer just a heads-up that @marcocuturi refactored the code #472 , so you might need to adjust the notebook a bit again.

@marcocuturi
Copy link
Contributor

thanks @Daniel-Packer , as Michal was mentioning I refactored the univariate solvers code (and Michal also had an extra pass)

@michalk8
Copy link
Collaborator

michalk8 commented Jun 5, 2024

Closing this, since the univariate solvers have been refactored again in #505

@michalk8 michalk8 closed this Jun 5, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.54%. Comparing base (f139415) to head (8ff9fb5).
Report is 89 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #456   +/-   ##
=======================================
  Coverage   90.54%   90.54%           
=======================================
  Files          59       59           
  Lines        6367     6367           
  Branches      897      897           
=======================================
  Hits         5765     5765           
  Misses        462      462           
  Partials      140      140           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants