Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leaderboard tiers filter with new API changes #142

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Conversation

AkinariHex
Copy link
Collaborator

This PR change the tiers filter for leaderboards page accordingly to the new API change:

closes #138

@AkinariHex AkinariHex requested a review from hburn7 March 24, 2024 17:36
Copy link
Collaborator

@hburn7 hburn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite understand all of the code changes. Assuming Akinari has tested thoroughly.

@AkinariHex
Copy link
Collaborator Author

I don't quite understand all of the code changes. Assuming Akinari has tested thoroughly.

The changes I made:

  • remove the excluded Tiers and rename the old variables name of Ranks with tiers.
  • made the checkbox to have only 2 states, selected and blank.
  • fixed incorrect pushing of tiers selected in the url bar
  • the website is sending to the api only the selected tiers as true value

@hburn7
Copy link
Collaborator

hburn7 commented Mar 24, 2024

I don't quite understand all of the code changes. Assuming Akinari has tested thoroughly.

The changes I made:

* remove the excluded Tiers and rename the old variables name of `Ranks` with `tiers`.

* made the checkbox to have only 2 states, selected and blank.

* fixed incorrect pushing of tiers selected in the url bar

* the website is sending to the api only the selected tiers as `true` value

Great, thanks for the breakdown.

@myssto myssto merged commit 36e231a into develop Mar 25, 2024
@myssto myssto deleted the feature/138 branch March 25, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants