Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address new proposed leaderboard filter behavior #216

Closed
4 tasks done
hburn7 opened this issue Mar 21, 2024 · 0 comments
Closed
4 tasks done

Address new proposed leaderboard filter behavior #216

hburn7 opened this issue Mar 21, 2024 · 0 comments

Comments

@hburn7
Copy link
Collaborator

hburn7 commented Mar 21, 2024

Objective

The way leaderboard filters work currently is very strange. @AkinariHex proposed in Discord that we change the behavior to the following:

  • Replace current leaderboard filter behavior with new behavior as defined below.
  • By default, on the frontend, no items are checked. This is the default leaderboard.
  • When a user engages the filtering system by clicking one of the checkboxes, any tier checked should be specifically included in the results. If the user clicks all checkboxes, or has no checkboxes checked, the leaderboard will return in its unfiltered state.

Acceptance Criteria

  • Leaderboard filter no longer uses nullable bools (bool?) and instead uses the standard bool type.
  • Tiers with the filter as true will be explicitly included in the query, assuming no other criteria prevents them from showing up (e.g. if someone searches for bronze players with 3000 rating, the query will not return any results).
  • Tiers with the filter as false will not be included if any other tiers are listed as true. Otherwise, no logic is performed
  • If all tiers are marked as true, return the default leaderboard.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants