[merged] Libcurl prep #651
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was making some other changes in this code, and noticed that we were adding checksums without object types into the same hash table for metadata. We should *never* do this with both metadata content objects, since in theory a content object could have the same hash as metadata. I don't actually think it's possible in practice for pure metadata to collide, since they have different structures, but let's do this anyways since it's conceptually right.
This is prep for the libcurl porting. `GTlsCertificate/GTlsDatabase` are abstract classes implemented in glib-networking for gnutls. curl's APIs take file paths as strings, so it's easier to work on both if we move the GLib TLS bits into the libsoup code.
It turns out libsoup strips all whitespace even *inside* a URL. We could do that for libcurl too but...really, people shouldn't do that. In this test we were adding the trailing newline into the URL. If someone complains who is using the libcurl code we can deal with it then.
libcurl AFAICS doesn't have an API to convert HTTP code ➡️ error string, so let's make the test regexp operate on both.
Now that we're daemonizing, it's useful to have the logs. I wanted this while debugging cookies.
rh-atomic-bot
pushed a commit
that referenced
this pull request
Jan 19, 2017
This is prep for the libcurl porting. `GTlsCertificate/GTlsDatabase` are abstract classes implemented in glib-networking for gnutls. curl's APIs take file paths as strings, so it's easier to work on both if we move the GLib TLS bits into the libsoup code. Closes: #651 Approved by: giuseppe
rh-atomic-bot
pushed a commit
that referenced
this pull request
Jan 19, 2017
It turns out libsoup strips all whitespace even *inside* a URL. We could do that for libcurl too but...really, people shouldn't do that. In this test we were adding the trailing newline into the URL. If someone complains who is using the libcurl code we can deal with it then. Closes: #651 Approved by: giuseppe
rh-atomic-bot
pushed a commit
that referenced
this pull request
Jan 19, 2017
libcurl AFAICS doesn't have an API to convert HTTP code ➡️ error string, so let's make the test regexp operate on both. Closes: #651 Approved by: giuseppe
rh-atomic-bot
pushed a commit
that referenced
this pull request
Jan 19, 2017
Now that we're daemonizing, it's useful to have the logs. I wanted this while debugging cookies. Closes: #651 Approved by: giuseppe
|
☀️ Test successful - status-atomicjenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.