Skip to content

Commit

Permalink
tests: Don't inject newline in URL
Browse files Browse the repository at this point in the history
It turns out libsoup strips all whitespace even *inside* a URL. We could do that
for libcurl too but...really, people shouldn't do that. In this test we were
adding the trailing newline into the URL. If someone complains who is using the
libcurl code we can deal with it then.

Closes: #651
Approved by: giuseppe
  • Loading branch information
cgwalters authored and rh-atomic-bot committed Jan 19, 2017
1 parent e6952de commit 56891f9
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions tests/test-pull-c.c
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ test_data_init (TestData *td)
if (!g_file_get_contents ("httpd-address", &http_address, NULL, error))
goto out;

g_strstrip (http_address);

repo_url = g_strconcat (http_address, "/ostree/gnomerepo", NULL);

{ g_autoptr(GVariantBuilder) builder = g_variant_builder_new (G_VARIANT_TYPE ("a{sv}"));
Expand Down

0 comments on commit 56891f9

Please sign in to comment.