[merged] Support for selective pruning #646
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are use cases for having a single repo with branches with different lifecycles; a simple example of what I was trying to do in CentOS Atomic Host work is have "stable" and "devel" branches, were we want to prune devel, but retain *all* of stable. This patch is split into two parts - first we add a low level "delete all objects not in this set" API, and change the current prune API to use this. Next, we move more logic into the "ostree prune" command. This paves the way for demonstrating how more sophisticated algorithms/logic could be developed outside of the ostree core. Also, the --keep-younger-than logic already lived in the commandline, so it makes sense to keep extending it there. Closes: ostreedev#604
cgwalters
force-pushed
the
selective-prune
branch
from
2dbcb10 to
66a48e0
Compare
|
Removing WIP, should be good to go. |
cgwalters
changed the title
jlebon
requested changes
Jan 18, 2017
| @@ -371,12 +371,10 @@ global: | |||
| * NOTE NOTE NOTE | |||
| */ | |||
|
|
|||
| /* Remove comment when first new symbol is added | |||
| LIBOSTREE_2016.XX { | |||
| LIBOSTREE_2016.15 { | |||
| goto out; | ||
| } | ||
| g_hash_table_insert (retain_branch_depth, g_strndup (bd, eq - bd), | ||
| GINT_TO_POINTER ((int)g_ascii_strtoll (eq + 1, NULL, 10))); |
There was a problem hiding this comment.
Since this is directly user-facing, we should probably validate that g_ascii_strtoll converted successfully. Otherwise, a typo can end up pruning the whole branch.
|
OK, fixups ⬆️ |
|
Yum, delicious fixups! |
|
☀️ Test successful - status-atomicjenkins |
rh-atomic-bot
changed the title
cgwalters
added a commit
to cgwalters/ostree
that referenced
this pull request
Sep 1, 2017
In 5c94098 / ostreedev#646 we added `--retain-branch-depth`; this adds a symmetric `--only-branch` for the case where a repo owner just wants to prune a specific branch. The implementation here is pretty straightforward; we just walk all refs and inject the equivalent of `--retain-branch-depth=$ref=-1` if they're *not* in `--only-branch`. Closes: ostreedev#1115
cgwalters
added a commit
to cgwalters/ostree
that referenced
this pull request
Sep 7, 2017
In 5c94098 / ostreedev#646 we added `--retain-branch-depth`; this adds a symmetric `--only-branch` for the case where a repo owner just wants to prune a specific branch. The implementation here is pretty straightforward; we just walk all refs and inject the equivalent of `--retain-branch-depth=$ref=-1` if they're *not* in `--only-branch`. Closes: ostreedev#1115
cgwalters
added a commit
to cgwalters/ostree
that referenced
this pull request
Sep 12, 2017
In 5c94098 / ostreedev#646 we added `--retain-branch-depth`; this adds a symmetric `--only-branch` for the case where a repo owner just wants to prune a specific branch. The implementation here is pretty straightforward; we just walk all refs and inject the equivalent of `--retain-branch-depth=$ref=-1` if they're *not* in `--only-branch`. Closes: ostreedev#1115
rh-atomic-bot
pushed a commit
that referenced
this pull request
Sep 18, 2017
In 5c94098 / #646 we added `--retain-branch-depth`; this adds a symmetric `--only-branch` for the case where a repo owner just wants to prune a specific branch. The implementation here is pretty straightforward; we just walk all refs and inject the equivalent of `--retain-branch-depth=$ref=-1` if they're *not* in `--only-branch`. Closes: #1115 Closes: #1127 Approved by: jlebon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.