-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFE: finer grain controls for pruning #1115
Comments
Since FAH today doesn't use https://github.com/ostreedev/ostree-releng-scripts/blob/master/do-release-tags - the whole commit stream needs to be protected right? We could prune the "not released" commits but as soon as we did that it would completely break the ability to traverse the history. This is another reason to do commit promotion like that script implements. |
No functional changes, all straightforward. Prep for ostreedev#1115
In 5c94098 / ostreedev#646 we added `--retain-branch-depth`; this adds a symmetric `--only-branch` for the case where a repo owner just wants to prune a specific branch. The implementation here is pretty straightforward; we just walk all refs and inject the equivalent of `--retain-branch-depth=$ref=-1` if they're *not* in `--only-branch`. Closes: ostreedev#1115
PR in #1127 |
In 5c94098 / ostreedev#646 we added `--retain-branch-depth`; this adds a symmetric `--only-branch` for the case where a repo owner just wants to prune a specific branch. The implementation here is pretty straightforward; we just walk all refs and inject the equivalent of `--retain-branch-depth=$ref=-1` if they're *not* in `--only-branch`. Closes: ostreedev#1115
I guess you are right, unless we did something like #954
doesn't that script create a new commit when it promotes a release? While that does make the history cleaner, one drawback is that we no longer are running tests against the same commit that is released. Technically it's the same so I guess it doesn't matter, but it's really nice when the hash we test against doesn't change. One alternative approach would be for us to compose each time using the previous two week release ref as the 'starting point'. We wouldn't need to do-release-tags but we'd also have no history for our updates ref. This is worth some more discussion at some point. |
New commit, same content. We talked in person before about having ostree display a "content hash" instead of commit. |
(Well s/instead of/in addition to/ and there's clearly lots of implications from that - big picture though I think we should focus on version identifiers...so the promoted commit would have the same version and we'd treat that the same) |
In 5c94098 / ostreedev#646 we added `--retain-branch-depth`; this adds a symmetric `--only-branch` for the case where a repo owner just wants to prune a specific branch. The implementation here is pretty straightforward; we just walk all refs and inject the equivalent of `--retain-branch-depth=$ref=-1` if they're *not* in `--only-branch`. Closes: ostreedev#1115
As we start to march towards a unified repo for Fedora Atomic Host we need more control around pruning. Some examples include:
fedora/26/x86_64/testing
older than 30 daysfedora/26/x86_64/atomic-host
that don't point to commit=xxyyzz. This would enable us to prune all static deltas that don't point to the latest commit for a ref.The text was updated successfully, but these errors were encountered: