lib/commit: fix using uninitialized var #1216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a few comments for each of the central functions used for committing data from a directory. Took me a bit to understand the relationship between those functions.
Noticed this while reading the code. The `child` var hasn't been initialized yet at the time we throw this error (and even then, it's only conditionally initialized). To be nice, let's just always calculate the child path and pass that along. Also do some minor style porting to decl near use.
cgwalters
reviewed
Sep 26, 2017
| g_ptr_array_add (path, (char*)name); | ||
|
|
||
| if (modifier != NULL) | ||
| child_relpath = ptrarray_path_join (path); | ||
| g_autofree char *child_relpath = ptrarray_path_join (path); |
There was a problem hiding this comment.
IIRC I did this intentionally to avoid the malloc if we didn't have a commit modifier. But eh, perhaps down the line we can tweak this to use a scratch GString buffer like we do in other places.
rh-atomic-bot
pushed a commit
that referenced
this pull request
Sep 26, 2017
Noticed this while reading the code. The `child` var hasn't been initialized yet at the time we throw this error (and even then, it's only conditionally initialized). To be nice, let's just always calculate the child path and pass that along. Also do some minor style porting to decl near use. Closes: #1216 Approved by: cgwalters
|
☀️ Test successful - status-atomicjenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this while reading the code. The
childvar hasn't beeninitialized yet at the time we throw this error (and even then, it's
only conditionally initialized). To be nice, let's just always calculate
the child path and pass that along.
Also do some minor style porting to decl near use.
Split out from #1170.