Skip to content

Commit

Permalink
lib/commit: add comments to explain dir commit path
Browse files Browse the repository at this point in the history
Add a few comments for each of the central functions used for committing
data from a directory. Took me a bit to understand the relationship
between those functions.

Closes: #1216
Approved by: cgwalters
  • Loading branch information
jlebon authored and rh-atomic-bot committed Sep 26, 2017
1 parent 8a7a359 commit e5c86fa
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions src/libostree/ostree-repo-commit.c
Original file line number Diff line number Diff line change
Expand Up @@ -2480,6 +2480,10 @@ write_dfd_iter_to_mtree_internal (OstreeRepo *self,
GCancellable *cancellable,
GError **error);

/* Given either a dir_enum or a dfd_iter, writes the directory entry to the mtree. For
* subdirs, we go back through either write_dfd_iter_to_mtree_internal (dfd_iter case) or
* write_directory_to_mtree_internal (dir_enum case) which will do the actual dirmeta +
* dirent iteration. */
static gboolean
write_directory_content_to_mtree_internal (OstreeRepo *self,
OstreeRepoFile *repo_dir,
Expand Down Expand Up @@ -2632,6 +2636,8 @@ write_directory_content_to_mtree_internal (OstreeRepo *self,
return TRUE;
}

/* Handles the dirmeta for the given GFile dir and then calls
* write_directory_content_to_mtree_internal() for each directory entry. */
static gboolean
write_directory_to_mtree_internal (OstreeRepo *self,
GFile *dir,
Expand Down Expand Up @@ -2729,6 +2735,8 @@ write_directory_to_mtree_internal (OstreeRepo *self,
return TRUE;
}

/* Handles the dirmeta for the dir described by src_dfd_iter and then calls
* write_directory_content_to_mtree_internal() for each directory entry. */
static gboolean
write_dfd_iter_to_mtree_internal (OstreeRepo *self,
GLnxDirFdIterator *src_dfd_iter,
Expand Down

0 comments on commit e5c86fa

Please sign in to comment.