Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Jackson to kotlinx-serialization (KxS) #3904

Open
sschuberth opened this issue Apr 18, 2021 · 7 comments
Open

Migrate from Jackson to kotlinx-serialization (KxS) #3904

sschuberth opened this issue Apr 18, 2021 · 7 comments
Labels
enhancement Issues that are considered to be enhancements model About the data model

Comments

@sschuberth
Copy link
Member

sschuberth commented Apr 18, 2021

Benefits of kotlinx-serialization:

Blockers for the migration to kotlinx-serialization:

Current Gradle modules that still depend on Jackson (edited as needed):

  • commands-api (and related, 9 imports)
  • common-utils (3 imports)
  • evaluated-model (30 imports)
  • fossid-webapp (34 imports)
  • helper-cli (10 imports)
  • model (128 imports)
  • scanner (15 imports)
  • spdx(-utils) (44 imports)
  • test-utils (1 import)
@sschuberth sschuberth added on hold Pull requests that cannot currently be merged enhancement Issues that are considered to be enhancements model About the data model labels Apr 18, 2021
@sschuberth sschuberth changed the title Think about migration from Jackson to kotlinx-serialization Think about migrating from Jackson to kotlinx-serialization Apr 18, 2021
@sschuberth

This comment was marked as outdated.

@sschuberth

This comment was marked as outdated.

@sschuberth

This comment was marked as resolved.

@sschuberth sschuberth changed the title Think about migrating from Jackson to kotlinx-serialization Migrate from Jackson to kotlinx-serialization eventually Aug 13, 2021
sschuberth added a commit that referenced this issue Sep 23, 2021
See #3904 for some background information.

Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth added a commit that referenced this issue Sep 24, 2021
See #3904 for some background information.

Signed-off-by: Sebastian Schuberth <[email protected]>
@sschuberth

This comment was marked as resolved.

@sschuberth

This comment was marked as resolved.

@sschuberth sschuberth removed the on hold Pull requests that cannot currently be merged label Feb 24, 2023
@sschuberth

This comment was marked as resolved.

@sschuberth
Copy link
Member Author

An interesting article about why not to use Jackson: https://blog.lahteenmaki.net/making-jackson-tolerable.html

sschuberth added a commit that referenced this issue May 24, 2023
To avoid both Jackson and kotlinx-serialization annotations on the
`SpdxExpression` (sealed) class, simply change the `spdx` property to be
a `String`.

This is part of #3904.

Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth added a commit that referenced this issue May 24, 2023
To avoid both Jackson and kotlinx-serialization annotations on the
`SpdxExpression` (sealed) class, simply change the `spdx` property to be
a `String`.

This is part of #3904.

Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth added a commit that referenced this issue May 25, 2023
To avoid both Jackson and kotlinx-serialization annotations on the
`SpdxExpression` (sealed) class, simply change the `spdx` property to be
a `String`.

This is part of #3904.

Signed-off-by: Sebastian Schuberth <[email protected]>
@sschuberth sschuberth changed the title Migrate from Jackson to kotlinx-serialization eventually Migrate from Jackson to kotlinx-serialization (KxS) Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues that are considered to be enhancements model About the data model
Projects
None yet
Development

No branches or pull requests

1 participant