Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the Opossum reporter from Jackson to kotlinx-serialization (KxS) #8839

Closed
sschuberth opened this issue Jul 3, 2024 · 8 comments · Fixed by #9484
Closed

Migrate the Opossum reporter from Jackson to kotlinx-serialization (KxS) #8839

sschuberth opened this issue Jul 3, 2024 · 8 comments · Fixed by #9484
Labels
enhancement Issues that are considered to be enhancements reporter About the reporter tool

Comments

@sschuberth
Copy link
Member

Ideally, this would also refactor the code to use properly typed data classes.

This is part of the #3904 effort.

@sschuberth sschuberth added enhancement Issues that are considered to be enhancements reporter About the reporter tool labels Jul 3, 2024
@sschuberth
Copy link
Member Author

@maxhbr is this something you could help with? Is there maybe even a JSON schema for Opossum that we could generate Kotlin code from?

@maxhbr
Copy link
Contributor

maxhbr commented Jul 3, 2024

Hey, I posted it in our group chat.

@sschuberth
Copy link
Member Author

Hey, I posted it in our group chat.

Were there any responses @maxhbr?

@sschuberth sschuberth changed the title Migrate the Opossum reporter from Jackson to KxS Migrate the Opossum reporter from Jackson to kotlinx-serialization (KxS) Jul 17, 2024
@sschuberth
Copy link
Member Author

Hey, I posted it in our group chat.

Were there any responses @maxhbr?

@maxhbr is the Opossum reporter still in use from your side? Otherwise we could consider removing it from ORT instead of investing the time to migrate it to KxS.

@leslielazzarino
Copy link

Yeah, we are difinitely still using it.

@sschuberth
Copy link
Member Author

Yeah, we are difinitely still using it.

Thanks @leslielazzarino for the comment. Is there also willingness to help maintaining it from your side, and assist with the migration to KxS?

@alexzurbonsen
Copy link

Hi @sschuberth I am taking a look.

@sschuberth
Copy link
Member Author

Hi @sschuberth I am taking a look.

Thank you @alexzurbonsen 🙏🏻

Ideally, the conversion would not be done by simply migrating those untyped maps to KxS equivalents, but by introducing a proper data model class (like e.g. for AOSD) at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues that are considered to be enhancements reporter About the reporter tool
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants