Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New yaml for wildlife encounter task #39

Merged
merged 6 commits into from
Nov 5, 2021
Merged

Conversation

M1chaelM
Copy link
Collaborator

@M1chaelM M1chaelM commented Nov 4, 2021

  • This PR adds a wildlife.yaml file that generates three practice worlds similar to the 3 stored in the vrx repository under vrx_gazebo/worlds/2022_practice.
  • It requires the new file wildlife.xacro in the vrx repository, so this PR must be tested in conjunction with PR 390 of that repository.

How to test:

These instructions assume you have a workspace at ~/vrx_ws with both vrx and vrx-docker installed, and have checked out the M1chaelM/wildlife_xacro branch in vrx.

  • First, switch to the root of the vrx-docker repository.
    cd ~/vrx_ws/src/vrx-docker
    
  • Set some variables for convenience:
    TASK=wildlife
    TRIAL=0
    
  • Generate the trial worlds for the task
    ./prepare_task_trials.bash $TASK
    
  • Verify that 3 worlds are generated without errors (except the expected REQUIRED process [world_gen-2] has died! message).
  • Now for each trial, 0-2
    • Test that the generated world runs:
      roslaunch vrx_gazebo vrx.launch world:=`pwd`/generated/task_generated/${TASK}/worlds/${TASK}${TRIAL}.world verbose:=true wamv_locked:=true
      
    • Check that the generated world matches the corresponding world in vrx/vrx_gazebo/worlds/2022_practice in all important details. The way I do this is by looking at the diff with vimdiff. For example:
      cd ~/vrx_ws/src/
      vimdiff vrx-docker/generated/task_generated/${TASK}/worlds/${TASK}${TRIAL}.world 
      vrx/vrx_gazebo/worlds/2022_practice/${TASK}${TRIAL}.world
      

Copy link
Contributor

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me!

@M1chaelM M1chaelM merged commit 5b17747 into master Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants