Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the so-far-missing support for torque limit control for robots with flippers. Having this allows making much better controllers.
Depends on gazebosim/gz-sim#847, gazebosim/gz-physics#260 and maybe gazebo-forks/dart#26 .
The code explicitly checks if the torque limit isn't larger than the
<joint effort="">
attribute in SDF, so it shouldn't be possible to create unrealistically strong flippers.How to test: