Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model submission for Gagarin sensor configuration 1 by CERBERUS #518

Conversation

mihirk284
Copy link
Contributor

Model Submission for the CERBERUS Gagarin with Sensor Configuration 1.
Image from iOS

@mihirk284 mihirk284 changed the title Model submission for Gagarin sensor configuration 1 from CERBERUS Model submission for Gagarin sensor configuration 1 by CERBERUS Aug 1, 2020
@mihirk284 mihirk284 marked this pull request as ready for review August 1, 2020 18:37
@angelacmaio angelacmaio changed the base branch from master to cave_feature_release6 August 3, 2020 23:16
@acschang
Copy link
Contributor

acschang commented Aug 4, 2020

The initial assessment of the CERBERUS Gagarin model is complete. No further action is required at this time. You can track the progress of your submission in PR #521 once this one is merged. If you have any late additions, please submit a new PR to cave_feature_release6

@nkoenig nkoenig requested a review from iche033 August 4, 2020 16:26
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, only a few minor comments. Sensor data look fine in rviz, tf tree also looks good, and battery life measures ~5min sim time as per spec.

@nkoenig
Copy link
Contributor

nkoenig commented Aug 6, 2020

@mihirk284 , I've adjusted the starting z-offset of Gagarin in order to support marsupial pairing.See ntnu-arl#1.

@nkoenig
Copy link
Contributor

nkoenig commented Aug 6, 2020

Thanks for the submission @mihirk284 . I've moved these models to #527 and will close this PR.

@nkoenig nkoenig closed this Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants