Fix supported shader types (normal_map_X_space) #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## sdf8 #383 +/- ##
==========================================
- Coverage 87.56% 87.54% -0.03%
==========================================
Files 54 54
Lines 7300 7304 +4
==========================================
+ Hits 6392 6394 +2
- Misses 908 910 +2
Continue to review full report at Codecov.
|
iche033
approved these changes
Oct 9, 2020
|
@osrf-jenkins run tests please (just checking that new setting in not broken) |
scpeters
pushed a commit
to scpeters/sdformat
that referenced
this pull request
Oct 9, 2020
Signed-off-by: Louise Poubel <[email protected]>
scpeters
pushed a commit
that referenced
this pull request
Oct 9, 2020
Signed-off-by: Louise Poubel <[email protected]>
scpeters
pushed a commit
to scpeters/sdformat
that referenced
this pull request
Oct 9, 2020
Signed-off-by: Louise Poubel <[email protected]>
scpeters
pushed a commit
that referenced
this pull request
Oct 12, 2020
Signed-off-by: Louise Poubel <[email protected]>
scpeters
pushed a commit
that referenced
this pull request
Oct 12, 2020
Signed-off-by: Louise Poubel <[email protected]>
scpeters
pushed a commit
that referenced
this pull request
Oct 12, 2020
Signed-off-by: Louise Poubel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going over models on the Gazebo model database, I don't see a single model that uses:
Instead, there are models using:
I suspect that the documentation has been wrong all along, and when the
sdf::Materialclass was created, the error was propagated.The fix here changes the documentation to the "correct" values, but keeps the "old" values supported to avoid breaking existing code.