Cherry-pick #383 forward to master: Fix supported shader types (normal_map_X_space) #387
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #383 forward to master, and I amended it to include the change in the
sdf/1.8
folder. Use rebase and merge.Original description:
Going over models on the Gazebo model database, I don't see a single model that uses:
Instead, there are models using:
I suspect that the documentation has been wrong all along, and when the
sdf::Material
class was created, the error was propagated.The fix here changes the documentation to the "correct" values, but keeps the "old" values supported to avoid breaking existing code.