Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Garden: fix physics, rendering, transport rpath issues and add tests #2409

Merged
merged 9 commits into from
Sep 18, 2023

Conversation

scpeters
Copy link
Member

This adds custom CMAKE_INSTALL_RPATH entries for
formulae with binaries installed to nested subfolders, such as /libexec/gz/transport12 and
/lib/gz-physics-6/engine-plugins.
This should fix library loading issues with ARM CPUs. This adds tests as well.

  • gz-rendering: patch for ogre2 rpath

This is a follow-up to #2404.

I'm having trouble with gz-gui, but have fixed the other packages.

This adds custom CMAKE_INSTALL_RPATH entries for
formulae with binaries installed to nested subfolders,
such as <prefix>/libexec/gz/transport12 and
<prefix>/lib/gz-physics-6/engine-plugins.
This should fix library loading issues with ARM CPUs.
This adds tests as well.

* gz-rendering: patch for ogre2 rpath

Signed-off-by: Steve Peters <[email protected]>
@scpeters
Copy link
Member Author

build bottle

@scpeters
Copy link
Member Author

build bottle

Signed-off-by: Steve Peters <[email protected]>
@scpeters
Copy link
Member Author

build bottle

@iche033
Copy link
Contributor

iche033 commented Sep 16, 2023

what's the proper way to install and test this? I installed by doing brew install --build-from-source ./gz-<lib_name>.rb and then was able to launch gz sim -v 4 -s shapes.sdf but when launching the gui, the gui plugins (in both gz-sim and gz-gui) complain about rpath issues.

@scpeters
Copy link
Member Author

what's the proper way to install and test this? I installed by doing brew install --build-from-source ./gz-<lib_name>.rb and then was able to launch gz sim -v 4 -s shapes.sdf but when launching the gui, the gui plugins (in both gz-sim and gz-gui) complain about rpath issues.

I can't figure out how to fix the rpath issues for the gz-gui plugins, and I forgot one of the gz-sim gui plugin folders, so this PR is just about getting the gz-sim server running.

@iche033
Copy link
Contributor

iche033 commented Sep 16, 2023

I can't figure out how to fix the rpath issues for the gz-gui plugins, and I forgot one of the gz-sim gui plugin folders, so this PR is just about getting the gz-sim server running.

ok got it. gz sim -s works for me.

@scpeters scpeters changed the title Garden: fix most rpath issues and add tests Garden: fix physics, rendering, transport rpath issues and add tests Sep 18, 2023
@scpeters
Copy link
Member Author

I've tracked down the issues with the gui plugins, and it will require further changes to gz-sim7, so I've redacted those changes from this pull request and will update it in a follow-up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants