gz-plugin: fix rpath for libexec/gz/plugin2 #2404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an rpath entry with a relative path from the libexec subfolder containing the CLI executable to lib. Signed-off-by: Steve Peters <[email protected]>
|
build bottle |
This was referenced Sep 15, 2023
|
Should the same rpath fixes be applied to Harmonic-related formulas? @scpeters |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an rpath entry with a relative path from the libexec subfolder containing the CLI executable to lib.
Fixes #2403 (comment).
This could alternatively be fixed in gz-plugin with something like gazebosim/gz-plugin@c5d69a4.
For reference, I copied the implementation for this from the arrayfire formula in homebrew-core.