-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for MOI v0.9 #55
Conversation
@bstellato bump, we released MOI v0.9 and we are about to release JuMP v0.20 |
Oops sorry. I have been busy with other stuff and release |
@bstellato I have updated the PR. It now fails because |
Thanks a lot @blegat! Unfortunately we do not return the dual objective value in OSQP since it would involve more complex operations such as computing the inverse of the quadratic form matrix |
Actually, there is no need to compute the inverse of However, I am not sure how useful this value will be in the case when the iterates are not dual feasible. For instance, it will not necessarily be a lower bound to the optimal objective value. |
Exactly! I meant the case where we do not depend on |
If |
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
- Coverage 87.59% 87.31% -0.29%
==========================================
Files 6 6
Lines 919 922 +3
==========================================
Hits 805 805
- Misses 114 117 +3
Continue to review full report at Codecov.
|
I moved the TODO list as separate issues. |
Silent
. It seems:verbose
is ignored when it is set byupdate_settings!
, i.e. byosqp_update_verbose
. @bstellato Any idea ?DualObjectiveValue
. @bstellato How do we get that from OSQP ?TimeLimitSec
.Support for
SingleVariable
is removed because the index should be equal to the variable index. It was bridged inside this wrapper anyway so it is better if it is not supported and relies onScalarFuntionizeBridge
: http://www.juliaopt.org/MathOptInterface.jl/dev/apireference/#MathOptInterface.Bridges.ScalarFunctionizeBridge