Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing statistics in TaxBrain difference table #770

Closed
martinholmer opened this issue Dec 11, 2017 · 7 comments · Fixed by #939
Closed

Missing statistics in TaxBrain difference table #770

martinholmer opened this issue Dec 11, 2017 · 7 comments · Fixed by #939
Labels

Comments

@martinholmer
Copy link
Contributor

martinholmer commented Dec 11, 2017

@martinholmer said in Tax-Calculator issue 1737:

Part of the problem in the TaxBrain difference table is that even though Tax-Calculator is computing a "Percentage Increase in After-Tax Expanded Income" statistic, TaxBrain is not yet displaying it. Again, this is a known problem with TaxBrain that we hope to fix soon.

I thought this was a "known problem", but I can't seem to find an issue that describes this as a high-priority enhancement to TaxBrain.

@martinholmer martinholmer changed the title Missing statistic in TaxBrain difference table Missing statistics in TaxBrain difference table Dec 11, 2017
@martinholmer
Copy link
Contributor Author

Actually there are two missing statistics in the TaxBrain difference table.
Here is the specification of the table in Tax-Calculator utils.py:

DIFF_TABLE_COLUMNS = ['count',
                      'tax_cut',
                      'perc_cut',
                      'tax_inc',
                      'perc_inc',
                      'mean',
                      'tot_change',
                      'share_of_change',
                      'perc_aftertax',
                      'pc_aftertaxinc']

DIFF_TABLE_LABELS = ['All Tax Units',
                     'Tax Units with Tax Cut',
                     'Percent with Tax Cut',
                     'Tax Units with Tax Increase',
                     'Percent with Tax Increase',
                     'Average Tax Change',
                     'Total Tax Difference',
                     'Share of Overall Change',
                     'Change as % of After-Tax Income',
                     '% Change in After-Tax Income']

TaxBrain displays only the first eight (of these ten) statistics. It needs to display all ten statistics.

@MaxGhenis
Copy link
Contributor

Are there still plans to add "Percentage Increase in After-Tax Expanded Income" to TaxBrain difference tables?

@martinholmer
Copy link
Contributor Author

There are (in PolicyBrain 1.5.0) still missing statistics in the difference table. The distribution table includes all the statistics generated by Tax-Calcalutor, but the difference table is missing two statistics: the consumption value of benefits and the percentage change in after-tax expanded income.

What's the schedule for fixing this bug?

@hdoupe @GoFroggyRun

@hdoupe
Copy link
Collaborator

hdoupe commented Apr 23, 2018

Thanks for the bug report @martinholmer. I will address the schedule for this in a separate issue.

@martinholmer
Copy link
Contributor Author

@hdoupe, the bug report in issue #770 has been open for almost 11 months.
What's the timeframe for fixing these problems with the difference tables?

@hdoupe
Copy link
Collaborator

hdoupe commented Nov 1, 2018

@martinholmer thanks for bringing this back up. It is likely that this was resolved or at least, the power to resolve it was handed back to the Tax-Calculator project by the backwards-incompatible changes made in PR #921. The fixes from #921 are no longer on the test app because I needed to test out v1.7.2_rc1. I hope to have a better version of Tax-Calculator running on the webapp in the next month or two.

@martinholmer
Copy link
Contributor Author

Issue #770 has been resolved by pull request #939 commit 27238a4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants