Add missing protobuf definitions #8600
Conversation
WalkthroughThe recent changes introduce several new Protocol Buffers files and message types within the Osmosis ecosystem, focusing on asset transfer functionalities and governance mechanisms. Key updates include the addition of Protobuf definitions for asset management, events related to asset transfers, and new transaction methods. These modifications enhance the interoperability and robustness of the Osmosis blockchain, particularly in managing cross-chain transactions and asset governance processes. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Bridge
participant ExternalChain
participant Osmosis
User->>Bridge: InboundTransfer(assetID, amount)
Bridge->>ExternalChain: ValidateTransfer(assetID, amount)
ExternalChain-->>Bridge: TransferApproved
Bridge->>Osmosis: MintTokens(assetID, amount)
Osmosis-->>Bridge: TokensMinted
Bridge-->>User: TransferSuccess
sequenceDiagram
participant User
participant LockupService
User->>LockupService: MsgUnlockPeriodLock(owner, ID)
LockupService-->>User: LockUnlocked
sequenceDiagram
participant Admin
participant ProtorevService
Admin->>ProtorevService: MsgSetPoolWeights(poolWeights)
ProtorevService-->>Admin: WeightsSet
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (4)
Additional comments not posted (8)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
penso
changed the title
Yes, those proto messages are on chain, but no proto definitions allowing to decode them. Adding those definitions from this PR I was able to index old blocks, outside a few which I think never got protobuf files committed anywhere. I was able to retrieve the ones in this PR going back in this repo Git history. Proto files should never be removed else you're preventing anyone to index/parse old blocks. |
|
@penso thanks for this! A couples points / questions
|
|
Also, @penso Did you ever get to try querying old state with these added? Did it work? 👀 |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
|
friendly ping here @penso, see: #8600 (comment) |
|
Ah yeah a few things to fix, will do them today. |
|
Fixed
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
CHANGELOG.md (1)
Line range hint
1-1: Convert TODO into a trackable task/issue.It's a good practice to capture TODO comments as trackable tasks/issues instead of leaving them in the code. Please create a task to track adding tests for this module.
|
@penso thanks for addressing these! @mattverse if you have time to give this a once over, if it looks good to you I think we are good to merge. |
What is the purpose of the change
This is adding missing protobuf definitions preventing Constellations from indexing, which would prevent anyone else as well.
Testing and Verifying
This change is a trivial rework / code cleanup without any test coverage.
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)