Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: x/gamm .proto file isn't compiled #8692

Closed
faddat opened this issue Sep 12, 2024 · 1 comment
Closed

[Bug]: x/gamm .proto file isn't compiled #8692

faddat opened this issue Sep 12, 2024 · 1 comment

Comments

@faddat
Copy link
Member

faddat commented Sep 12, 2024 •
edited
Loading

What happened?

The x/gamm .proto file from #8600 hasn't been built. But when it is built, there is a cycular dependency issue in main

Osmosis Version

main

How to reproduce?

Make a pull request that triggers the generate protofiles ci job. You'll then get:

and then a dependency cycle issue is triggered.

Solution?

I'm not fully sure but maybe we exclude that .proto from building?
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Osmosis Chain Development Sep 12, 2024
@PaddyMc
Copy link
Collaborator

PaddyMc commented Sep 23, 2024

Thanks for the issue, we reverted that PR => #8710

🙇

@PaddyMc PaddyMc closed this as completed Sep 23, 2024
@github-project-automation github-project-automation bot moved this from Needs Triage 🔍 to Done ✅ in Osmosis Chain Development Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PaddyMc @faddat