Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the typo of response field "recovery_addr" #6841

Merged
merged 7 commits into from
Nov 9, 2023
Merged

fix: fix the typo of response field "recovery_addr" #6841

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
511f3d1
fix: fix the typo of response field "recovery_addr"
Halimao Nov 8, 2023
71ac719
fix: fix typo of "Swaps"
Halimao Nov 8, 2023
f0abcd8
fix: fix the typo of "denom"
Halimao Nov 8, 2023
6b9de23
Update CHANGELOG.md
Halimao Nov 9, 2023
12ecad6
Merge branch 'osmosis-labs:main' into fix/response-field-typo
Halimao Nov 9, 2023
74ea77a
build: update crosschain_swaps.wasm
Halimao Nov 9, 2023
332906e
build: update outpost.wasm
Halimao Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

* [#6840](https://github.com/osmosis-labs/osmosis/pull/6840) fix: change TypeMsgUnbondConvertAndStake value to "unbond_convert_and_stake" and improve error message when epoch currentEpochStartHeight less than zero
* [#6769](https://github.com/osmosis-labs/osmosis/pull/6769) fix: improve dust handling in EstimateTradeBasedOnPriceImpact
* [#6841](https://github.com/osmosis-labs/osmosis/pull/6841) fix: fix receive_ack response field and imporove error message of InvalidCrosschainSwapsContract and NoDenomTrace

## v20.0.0

Expand Down
2 changes: 1 addition & 1 deletion cosmwasm/contracts/crosschain-swaps/src/ibc_lifecycle.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ pub fn receive_ack(

Ok(response
.add_attribute("msg", "recovery stored")
.add_attribute("reecovery_addr", recovery_addr))
.add_attribute("recovery_addr", recovery_addr))
}

// This is very similar to the handling of acks, but it always creates a
Expand Down
2 changes: 1 addition & 1 deletion cosmwasm/contracts/outpost/src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ pub enum ContractError {
#[error("SwapAmountTooHigh: got {received}, max allowed: {max}")]
SwapAmountTooHigh { received: u128, max: u128 },

#[error("Invalid Crosschain Swpas Contract: {contract}")]
#[error("Invalid Crosschain Swaps Contract: {contract}")]
InvalidCrosschainSwapsContract { contract: String },

#[error("Custom Error val: {val:?}")]
Expand Down
2 changes: 1 addition & 1 deletion cosmwasm/packages/registry/src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ pub enum RegistryError {
#[error("denom {denom:?} is not an IBC denom")]
InvalidIBCDenom { denom: String },

#[error("No deom trace found for: {denom:?}")]
#[error("No denom trace found for: {denom:?}")]
NoDenomTrace { denom: String },

#[error("Invalid denom trace: {error}")]
Expand Down