Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix the typo of response field "recovery_addr" #6841

Merged
merged 7 commits into from
Nov 9, 2023
Merged

fix: fix the typo of response field "recovery_addr" #6841

merged 7 commits into from
Nov 9, 2023

Conversation

Halimao
Copy link
Contributor

@Halimao Halimao commented Nov 8, 2023

What is the purpose of the change

fix the typo of response field "recovery_addr"

@mattverse mattverse added the V:state/breaking State machine breaking PR label Nov 9, 2023
mattverse
mattverse approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM

@mattverse
Copy link
Member

@Halimao Cosmwasm contract CI seems to be failing, can you recompile contract and replace the wasm file in artifacts/crosschain_swaps.wasm?

@Halimao
Copy link
Contributor Author

Halimao commented Nov 9, 2023

@Halimao Cosmwasm contract CI seems to be failing, can you recompile contract and replace the wasm file in artifacts/crosschain_swaps.wasm?

Hi @mattverse wasm files were updated

@mattverse
Copy link
Member

@Halimao Awesome thanks so much! :)

@mattverse mattverse merged commit 30b8e82 into osmosis-labs:main Nov 9, 2023
1 check passed
@Halimao Halimao deleted the fix/response-field-typo branch November 9, 2023 07:40
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pysel pysel pysel approved these changes

@mattverse mattverse mattverse approved these changes

Assignees
No one assigned
Labels
V:state/breaking State machine breaking PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Halimao @mattverse @pysel