chore: check all errors in tests #5104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:app-wiring
faddat
added
the
V:state/compatible/no_backport
faddat
requested review from
mattverse,
stackman27,
nicolaslara,
p0mvn and
czarcas7ic
as code owners
czarcas7ic
approved these changes
May 7, 2023
|
Ready to merge once few nits are addressed and PR is refreshed against |
|
Cool, refreshing now :) |
Co-authored-by: Roman <[email protected]>
pysel
pushed a commit
that referenced
this pull request
Jun 6, 2023
* run golangci-lint and resolve ineffectual assignment to err * go work sync * waypoint in "check all errors in tests" * 50 error checks remaining * 42 errors remaining to check in tests * all tests pass and as many errors as possible have been checked * revert enabling golangci-lint to check tests, as it would always fail afterwards * update changelog * use thelper in golangci-lint without linting every test * Update tests/e2e/containers/containers.go Co-authored-by: Roman <[email protected]> * thelper for incentives bench test * Update x/concentrated-liquidity/position_test.go Co-authored-by: Adam Tucker <[email protected]> * Update CHANGELOG.md Co-authored-by: Roman <[email protected]> * return error in SetIncentiveRecord * revert change to .golanci.yml --------- Co-authored-by: Roman <[email protected]> Co-authored-by: Adam Tucker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #5060
What is the purpose of the change
This PR is designed to enhance the rigor of tests in Osmosis by checking errors whenever possible.
It also extends the changes found in:
Note that the t.Helper() thing can be a bit all or nothing, so this PR contains those changes as well. If you'd prefer to close that one, no worries :).
By applying thelper to the whole repository. This is a part of an initiative to allow Osmosis to use golangci-lint on its tests, by setting
and then progressively adding additional tools like thelper. Note to vscode users: now that we're using t.Helper() at the beginning of every test helper, you'll get these really cool inline stack traces if there's an issue with a test.
Since we want golangci-lint to pass, this PR does not yet make the change to the configuration mentioned above, but it is what was used while writing the PR.
Brief Changelog
Testing and Verifying
This change is tests, and I suppose that the best way to test it is to maybe break some tests and check out the cool stack trace? I am actually not certain, but would love to hear ideas.
Reviewing
I'd recommend reviewing
before this one, it will reduce the size of this. To make sure that this merges smoothly, I cherry picked that into this.
There are about 200-300 miscellaneous linter changes that Id need to make for us to be able to enable the linter on the tests. I'm going to open one or more additional smaller PR's for that since I know this one is already pretty big.
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? yes