stlye: use thelper without linting every test #5064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faddat
requested review from
nicolaslara,
p0mvn,
czarcas7ic and
mattverse
as code owners
github-actions
bot
added
C:CLI
C:simulator
|
changelog reminder ftw |
faddat
added
V:state/compatible/backport
|
labels: backport but only to v15 |
p0mvn
approved these changes
May 3, 2023
Co-authored-by: Roman <[email protected]>
|
thank you for catching the dupe @p0mvn |
czarcas7ic
approved these changes
May 7, 2023
|
Thanks for the addition @faddat, merging! |
|
thanks :D it will make the linting of the tests way easier :) |
faddat
added
V:state/compatible/no_backport
pysel
pushed a commit
that referenced
this pull request
Jun 6, 2023
* use thelper in golangci-lint without linting every test * add changelog entry * Update tests/e2e/containers/containers.go Co-authored-by: Roman <[email protected]> --------- Co-authored-by: Roman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR introduces the thelper linter without moving to lint the tests. It also includes a breaking
change to an internal api, newSimulatorState() to make it more consistent the linter specifies that
the testing library be passed as the first parameter.
Brief Changelog
or tb.Helper()
Testing and Verifying
This change enhanced tests by allowing them to give more feedback to developers in some situations.
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? yes