Lower noise of e2e tests #3822
Merged
Lower noise of e2e tests #3822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
added
A:backport/v12.x
p0mvn
approved these changes
Dec 22, 2022
There was a problem hiding this comment.
There are cases when an actual error is produced neither to stdout, nor stderr. In such cases, if e2e happens to fail in CI but not locally, it becomes nearly impossible to debug without spitting out logs.
However, I guess we can turn on the debug flag temporarily and rerun the CI then
mergify bot
pushed a commit
that referenced
this pull request
Dec 22, 2022
(cherry picked from commit e4e6599) # Conflicts: # Makefile
mergify bot
pushed a commit
that referenced
this pull request
Dec 22, 2022
(cherry picked from commit e4e6599)
p0mvn
pushed a commit
that referenced
this pull request
Dec 22, 2022
(cherry picked from commit e4e6599) Co-authored-by: Dev Ojha <[email protected]>
p0mvn
added a commit
that referenced
this pull request
Dec 22, 2022
* Lower noise of e2e tests (#3822) (cherry picked from commit e4e6599) # Conflicts: # Makefile * Update Makefile * Update Makefile Co-authored-by: Dev Ojha <[email protected]> Co-authored-by: Roman <[email protected]>
|
Feels good only 400 lines now 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2653
What is the purpose of the change
Debugging E2E via CI is pretty unusable. It emits over 13000 log lines right now.
This PR:
I claim that this will massively reduce log output, and maintain the same debuggability.
Brief Changelog
Testing and Verifying
This change is a trivial rework / code cleanup without any test coverage.
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? yes