-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/e2e: revert logging all tx results #2653
Comments
I think this has significantly improved the debugging experience. If these are not present, it is close to impossible to tell what exactly happened in the failing container / why did a certain CLI command fail. In the long term, we should instead pipe logs from each container to a file and preserve them as artifacts after running the CI job. This would remove the need for the extra logging. However, in the meantime, I think having more logs is better than having none |
This is the log from the first TX I saw in the logs: https://pastebin.com/c94JZvwF Its about 400 lines. Not sure which part of this is helpful for debugging in the normal case, beyond WDYT about only logging this for a tx that fails, but not all succesful txs? |
Yes, this is not useful at all for regular cases. However, the goal here is to log so that we can see the reasons for failure when it fails
This is exactly the problem - it is hard to tell when a transaction is successful and when it is not in a general way Off the top of my head, the problems are:
I'm open to investigating identifying the tx fails more. However, from my previous attempts, there are quite a few edge cases to work around. I can try looking into this again after v12 |
Background
Not sure when it was added, but the e2e test suite is now logging all tx results. This should be reverted, as it massively crowds out the logs, and makes it hard to get relevant info at a glance. (Perhaps at most logging a tx hash by default, so you can quer)
If this is helpful for a particular debugging flow right now, we can add ways to improve that same debugging flows. (e.g. display results for last 3 txs)
The text was updated successfully, but these errors were encountered: