Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): parallelize tests to improve CI times #2646

Closed
Tracked by #4615
p0mvn opened this issue Sep 8, 2022 · 4 comments
Closed
Tracked by #4615

test(e2e): parallelize tests to improve CI times #2646

p0mvn opened this issue Sep 8, 2022 · 4 comments

Comments

@p0mvn
Copy link
Member

p0mvn commented Sep 8, 2022

Background

Since our tests are now independent, we can parallelize them to improve CI times

Suggested Design

Add s.T().Parallel() to the following:

  • TestIBCTokenTransferAndCreatePool
  • TestSuperfluidVoting
  • TestAddToExistingLockPostUpgrade
  • TestAddToExistingLock
  • TestTWAP
  • TestExpeditedProposals

Note:
TestStateSync cannot be parallelized

Acceptance Criteria

  • tests are parallelized
  • benchmark CI time improvement
  • ensure that the following still work locally:
    • make test-e2e-debug
    • make test-e2e-short
@p0mvn p0mvn moved this to Needs Review 🔍 in Osmosis Chain Development Sep 8, 2022
@p0mvn p0mvn moved this from Needs Review 🔍 to Todo 🕒 in Osmosis Chain Development Sep 8, 2022
@p0mvn
Copy link
Member Author

p0mvn commented Sep 8, 2022

ref: #2100

@p0mvn
Copy link
Member Author

p0mvn commented Sep 9, 2022

Might not be as simple as adding s.T().Parallel() due to the need for synchronizing some shared variables.

@ValarDragon
Copy link
Member

I also am suspicious that this is where the big speedup will come from, vs block time changes

Its a bit hard to see right now due to #2653 , but my recollection from before was that the time from traces looked to mostly be in waiting for blocks to occur.

@p0mvn p0mvn moved this from Todo 🕒 to Needs Review 🔍 in Osmosis Chain Development Jan 25, 2023
@p0mvn p0mvn moved this from Needs Review 🔍 to Todo 🕒 in Osmosis Chain Development Jan 25, 2023
@ThanhNhann ThanhNhann assigned ThanhNhann and unassigned ThanhNhann Jan 30, 2023
@czarcas7ic czarcas7ic moved this from Todo 🕒 to Needs Triage 🔍 in Osmosis Chain Development Mar 14, 2023
@czarcas7ic czarcas7ic moved this from Needs Triage 🔍 to Todo 🕒 in Osmosis Chain Development Mar 28, 2023
@czarcas7ic
Copy link
Member

@github-project-automation github-project-automation bot moved this from Todo 🕒 to Done ✅ in Osmosis Chain Development Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants