-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auto: update Go import paths to v10 #2115
Conversation
Would like for someone else to review this too, please. Just FYI, the reason why ValarDragon is the PR author is because his
|
uhhh, lets not use my access token for this. I'm going to see if I can revoke permissions for it to do this |
It actually shouldn't have any of these permissions to even open a PR. I'm confused, going to delete my PAT, and remake via osmo bot |
There are a few other actions that depend on PAT:
|
yeah, they're just going to broken for now until I get another acct to make the token from. But add_to_project_pat should have just had permissions for adding to the project (in fact the only thing github said it had write access to was projects ... . Explicitly did not give it any other write permission so I;m confused) PR opening deserves a second access token. It is different permissions (so it should have a different github secret all together) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What do folks think about creating an issue for creating a bot for automating this process when needed?
This is already automated by running this manual action: https://github.com/osmosis-labs/osmosis/actions/workflows/import_paths.yml |
Oh wow, didn't know we had this! |
yeah, we just added it on Friday. We need to figure out this problem with the token so that Dev is not the PR author for these changes. Other than that, it seems to be functioning correctly |
(new tokens made from osmobot) |
I'm going to merge this since there are 2 approvals and CI passes. Would like to avoid this to keep having merge conflicts with other PRs |
Awesome thanks! I will test if it's working shortly |
@ValarDragon what is the new token name? The old token does not work. I'm assuming that the old one is still associated with your account but has reduced permissions? |
|
Closes: #1709
Automated pull request
Updating Go import paths to v10