Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto: update Go import paths to v10 #2115

Merged
merged 2 commits into from
Jul 18, 2022
Merged

auto: update Go import paths to v10 #2115

merged 2 commits into from
Jul 18, 2022

Conversation

ValarDragon
Copy link
Member

@ValarDragon ValarDragon commented Jul 18, 2022

Closes: #1709

Automated pull request

Updating Go import paths to v10

@p0mvn p0mvn marked this pull request as ready for review July 18, 2022 03:23
@p0mvn p0mvn requested a review from a team July 18, 2022 03:23
@p0mvn
Copy link
Member

p0mvn commented Jul 18, 2022

Would like for someone else to review this too, please.

Just FYI, the reason why ValarDragon is the PR author is because his PAT token being used by the GitHub Action:

token: ${{ secrets.ADD_TO_PROJECT_PAT }}

@ValarDragon
Copy link
Member Author

ValarDragon commented Jul 18, 2022

uhhh, lets not use my access token for this. I'm going to see if I can revoke permissions for it to do this

@ValarDragon
Copy link
Member Author

It actually shouldn't have any of these permissions to even open a PR. I'm confused, going to delete my PAT, and remake via osmo bot

@p0mvn
Copy link
Member

p0mvn commented Jul 18, 2022

There are a few other actions that depend on PAT:

@ValarDragon
Copy link
Member Author

ValarDragon commented Jul 18, 2022

yeah, they're just going to broken for now until I get another acct to make the token from. But add_to_project_pat should have just had permissions for adding to the project (in fact the only thing github said it had write access to was projects ... . Explicitly did not give it any other write permission so I;m confused)

PR opening deserves a second access token. It is different permissions (so it should have a different github secret all together)

Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

What do folks think about creating an issue for creating a bot for automating this process when needed?

@p0mvn
Copy link
Member

p0mvn commented Jul 18, 2022

LGTM

What do folks think about creating an issue for creating a bot for automating this process when needed?

This is already automated by running this manual action: https://github.com/osmosis-labs/osmosis/actions/workflows/import_paths.yml

@mattverse
Copy link
Member

Oh wow, didn't know we had this!

@p0mvn
Copy link
Member

p0mvn commented Jul 18, 2022

Oh wow, didn't know we had this!

yeah, we just added it on Friday. We need to figure out this problem with the token so that Dev is not the PR author for these changes. Other than that, it seems to be functioning correctly

@ValarDragon
Copy link
Member Author

ValarDragon commented Jul 18, 2022

(new tokens made from osmobot)

@p0mvn
Copy link
Member

p0mvn commented Jul 18, 2022

I'm going to merge this since there are 2 approvals and CI passes. Would like to avoid this to keep having merge conflicts with other PRs

@p0mvn
Copy link
Member

p0mvn commented Jul 18, 2022

(new tokens made from osmobot)

Awesome thanks! I will test if it's working shortly

@p0mvn p0mvn merged commit 36a98c9 into main Jul 18, 2022
@p0mvn p0mvn deleted the update-paths-a3n8cci branch July 18, 2022 14:05
@p0mvn
Copy link
Member

p0mvn commented Jul 18, 2022

(new tokens made from osmobot)

@ValarDragon what is the new token name? The old token does not work. I'm assuming that the old one is still associated with your account but has reduced permissions?

@ValarDragon
Copy link
Member Author

COMMIT_TO_BRANCH
ADD_TO_PROJECT_PAT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Go module versioning
3 participants