Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go module versioning #1709

Closed
faddat opened this issue Jun 8, 2022 · 6 comments · Fixed by #2115
Closed

Go module versioning #1709

faddat opened this issue Jun 8, 2022 · 6 comments · Fixed by #2115
Assignees

Comments

@faddat
Copy link
Member

faddat commented Jun 8, 2022

For reasons that I don't yet understand, we have moved the main branch back to v7.

This is making reviews and contributions a bit more complicated for me, and I just wanted to know why that was done

@hleb-albau
Copy link
Contributor

can we use v9 for now?

@faddat
Copy link
Member Author

faddat commented Jun 8, 2022

@hleb-albau I don't know, that's actually the reason for this issue. Just seeking guidance on how to use the module version paths currently.

@p0mvn
Copy link
Member

p0mvn commented Jul 15, 2022

I think it's time to do this. Our main branch is still on v7. What do others think? I can create a PR today if we are good with this

@ValarDragon
Copy link
Member

ValarDragon commented Jul 15, 2022

Sure, please go for it. If you have time, want to also add a manually triggerable github workflow to do the find/replace to update all imports? (And then we can just manually trigger that for open PRs for now)

@p0mvn
Copy link
Member

p0mvn commented Jul 15, 2022

Sounds good, on it

@p0mvn
Copy link
Member

p0mvn commented Jul 17, 2022

The manual workflow is now in. However, the rest of the CI does not auto-run from the pull request triggered by the workflow (example #2096). The reason is a Github security limitation, ref: peter-evans/create-pull-request#48

One of the manual solutions is to close and reopen a PR (example #2101). There are more automatic solutions that are listed here: peter-evans/create-pull-request#48

Unfortunately, the currently chosen Github Action does not support any suggested automatic solutions. We would either have to fork the existing action and modify it or switch to: https://github.com/peter-evans/create-pull-request

I think closing and reopening to trigger CI is fine for the time being. This workflow is not meant to be run regularly anyways (only on major releases).

I'm still open to changing the action if it proves to be troublesome

Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
4 participants