Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor FundCommunityPoolFromModule to use SDK #1909

Merged
merged 1 commit into from
Jun 30, 2022
Merged

refactor FundCommunityPoolFromModule to use SDK #1909

merged 1 commit into from
Jun 30, 2022

Conversation

rrrliu
Copy link
Contributor

@rrrliu rrrliu commented Jun 30, 2022

Closes: #1401

What is the purpose of the change

Dedupes funding logic by having FundCommunityPoolFromModule in the pool-incentives module call FundCommunityPool in the Cosmos SDK.

Brief Changelog

  • Added FundCommunityPool to DistrKeeper interface
  • Refactored the FundCommunityPoolFromModule function

Testing and Verifying

This change is already covered by existing tests, such as tests in distr_test.go that call AllocateAsset, which uses FundCommunityPoolFromModule.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? n/a, but added a brief inline comment

@rrrliu rrrliu requested a review from a team June 30, 2022 09:49
alexanderbez
alexanderbez approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ValarDragon
ValarDragon approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@ValarDragon ValarDragon merged commit f79a273 into osmosis-labs:main Jun 30, 2022
@czarcas7ic czarcas7ic mentioned this pull request Aug 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValarDragon ValarDragon ValarDragon approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

Assignees
No one assigned
Labels
C:x/pool-incentives
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

x/pool-incentives: Make FundCommunityPoolFromModule call distr.FundCommunityPool
3 participants
@rrrliu @alexanderbez @ValarDragon