Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pool-incentives: Make FundCommunityPoolFromModule call distr.FundCommunityPool #1401

Closed
ValarDragon opened this issue May 3, 2022 · 4 comments · Fixed by #1909
Closed

Comments

@ValarDragon
Copy link
Member

The current FundCommunityPoolFromModule function in pool-incentives should either be upstreamed to the SDK's distribution module, or we should derive the SDK address for this, and call distr.FundCommunityPool.

We derive the SDK address from a module name via:

addr := k.accountKeeper.GetModuleAddress(moduleName)
if addr == nil {
  error or panic
}
@alexanderbez
Copy link
Contributor

@ValarDragon what exactly are you proposing we upstream to x/distribution?

@ValarDragon
Copy link
Member Author

The FundCommunityPoolFromModule function as a whole. The problem we faced was we wanted to send coins to the community pool from a module account, and in this code we basically hackily did updates to the Distr.FeeTokens struct to handle this.

@alexanderbez
Copy link
Contributor

alexanderbez commented May 3, 2022

Got it! Shouldn't this issue exist in the SDK then?

@ValarDragon
Copy link
Member Author

Oh true. I guess its a yak shaving question of do we want to get this into the SDK, versus just use more black box functionality here. (converting sending address to a normal address rather than module address)

Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants